-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow arbitrary axes for resample2d #752
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Thank you Phillis.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 LGTM. TY.
SHA: 355c38d Reason: push, by fdwr Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Allow arbitrary axes as long as they are valid dimensions for resample2d instead of restricting them to point to spacial dimensions. Apply transposes for input & output when the axes is not supported by the backend. See spec pr: webmachinelearning/webnn#752 Change-Id: I5112abf1f43328d901000a4cff8468bd9bfe2dfb Cq-Include-Trybots: luci.chromium.try:win11-blink-rel,mac14.arm64-blink-rel,mac14-blink-rel, linux-blink-rel Bug: 329658123, 334914468
Allow arbitrary axes as long as they are valid dimensions for resample2d instead of restricting them to point to spacial dimensions. Apply transposes for input & output when the axes is not supported by the backend. See spec pr: webmachinelearning/webnn#752 Change-Id: I5112abf1f43328d901000a4cff8468bd9bfe2dfb Cq-Include-Trybots: luci.chromium.try:win11-blink-rel,mac14.arm64-blink-rel,mac14-blink-rel, linux-blink-rel Bug: 329658123, 334914468 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5798093 Commit-Queue: Phillis Tang <[email protected]> Reviewed-by: ningxin hu <[email protected]> Reviewed-by: Alex Gough <[email protected]> Cr-Commit-Position: refs/heads/main@{#1346174}
Allow arbitrary axes as long as they are valid dimensions for resample2d instead of restricting them to point to spacial dimensions. Apply transposes for input & output when the axes is not supported by the backend. See spec pr: webmachinelearning/webnn#752 Change-Id: I5112abf1f43328d901000a4cff8468bd9bfe2dfb Cq-Include-Trybots: luci.chromium.try:win11-blink-rel,mac14.arm64-blink-rel,mac14-blink-rel, linux-blink-rel Bug: 329658123, 334914468 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5798093 Commit-Queue: Phillis Tang <[email protected]> Reviewed-by: ningxin hu <[email protected]> Reviewed-by: Alex Gough <[email protected]> Cr-Commit-Position: refs/heads/main@{#1346174}
Allow arbitrary axes as long as they are valid dimensions for resample2d instead of restricting them to point to spacial dimensions. Apply transposes for input & output when the axes is not supported by the backend. See spec pr: webmachinelearning/webnn#752 Change-Id: I5112abf1f43328d901000a4cff8468bd9bfe2dfb Cq-Include-Trybots: luci.chromium.try:win11-blink-rel,mac14.arm64-blink-rel,mac14-blink-rel, linux-blink-rel Bug: 329658123, 334914468 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5798093 Commit-Queue: Phillis Tang <[email protected]> Reviewed-by: ningxin hu <[email protected]> Reviewed-by: Alex Gough <[email protected]> Cr-Commit-Position: refs/heads/main@{#1346174}
…a=testonly Automatic update from web-platform-tests webnn: support all axes for resample2d Allow arbitrary axes as long as they are valid dimensions for resample2d instead of restricting them to point to spacial dimensions. Apply transposes for input & output when the axes is not supported by the backend. See spec pr: webmachinelearning/webnn#752 Change-Id: I5112abf1f43328d901000a4cff8468bd9bfe2dfb Cq-Include-Trybots: luci.chromium.try:win11-blink-rel,mac14.arm64-blink-rel,mac14-blink-rel, linux-blink-rel Bug: 329658123, 334914468 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5798093 Commit-Queue: Phillis Tang <[email protected]> Reviewed-by: ningxin hu <[email protected]> Reviewed-by: Alex Gough <[email protected]> Cr-Commit-Position: refs/heads/main@{#1346174} -- wpt-commits: 536c5951f70d77c0be08552be6bd5bbc2a082e5c wpt-pr: 47768
…a=testonly Automatic update from web-platform-tests webnn: support all axes for resample2d Allow arbitrary axes as long as they are valid dimensions for resample2d instead of restricting them to point to spacial dimensions. Apply transposes for input & output when the axes is not supported by the backend. See spec pr: webmachinelearning/webnn#752 Change-Id: I5112abf1f43328d901000a4cff8468bd9bfe2dfb Cq-Include-Trybots: luci.chromium.try:win11-blink-rel,mac14.arm64-blink-rel,mac14-blink-rel, linux-blink-rel Bug: 329658123, 334914468 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5798093 Commit-Queue: Phillis Tang <[email protected]> Reviewed-by: ningxin hu <[email protected]> Reviewed-by: Alex Gough <[email protected]> Cr-Commit-Position: refs/heads/main@{#1346174} -- wpt-commits: 536c5951f70d77c0be08552be6bd5bbc2a082e5c wpt-pr: 47768
…a=testonly Automatic update from web-platform-tests webnn: support all axes for resample2d Allow arbitrary axes as long as they are valid dimensions for resample2d instead of restricting them to point to spacial dimensions. Apply transposes for input & output when the axes is not supported by the backend. See spec pr: webmachinelearning/webnn#752 Change-Id: I5112abf1f43328d901000a4cff8468bd9bfe2dfb Cq-Include-Trybots: luci.chromium.try:win11-blink-rel,mac14.arm64-blink-rel,mac14-blink-rel, linux-blink-rel Bug: 329658123, 334914468 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5798093 Commit-Queue: Phillis Tang <[email protected]> Reviewed-by: ningxin hu <[email protected]> Reviewed-by: Alex Gough <[email protected]> Cr-Commit-Position: refs/heads/main@{#1346174} -- wpt-commits: 536c5951f70d77c0be08552be6bd5bbc2a082e5c wpt-pr: 47768
Fixs #624
This allow any arbitrary axes as long as they are valid dimensions for resample2d. Remove restriction on it to be the spacial dimensions.
Chromium prototype
@fdwr @huningxin
Preview | Diff