This repository has been archived by the owner on Aug 2, 2024. It is now read-only.
feat: add support to portuguese #325
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Tidy all routes on same indent level - Add route '/import'
(Duplicate from open view)
- Add Roel as current lead developer - Add WAI-Tools Project acknowledgment - Minor tweaks
* Update wcag2-en.json with wcag 2.1 SC * Update .editorconfig to format .json with 4 space indent * Remove techniques guideline and successcriteria key * Update EN locale to WCAG 2.1 or remove version where not explicit required * Update grunt to ^1.0.4 (latest) * Update grunt-html2js package (latest) * Update grunt-contrib-watch package (latest) * Update grunt-replace package (Latest) * Update grunt-contrib-jshint package (Latest) * Update grunt-wiredep package - Move jQuery Bower dependencies to top (jQuery > angular) - Replace jQuery dependency with injected by Bower (Wiredep) (Latest) * Update grunt-contrib-uglify package (Latest) * Update grunt-contrib-htmlmin package (Latest): - Remove edge case htmlmin options (Only required options) - Drop support for IE9 lte (Deprecated/unmaintained browser versions) * Update grunt-contrib-cssmin package (Latest) * Update grunt-contrib-clean package (Latest) * Update grunt-concat-json package (Latest, no custom versions) * Update grunt-autoprefixer (Latest) * Update grunt-concurrent (Latest) * Update grunt-contrib-compass * Update grunt-contrib-concat (Latest) * Update grunt-contrib-connect (Latest) * Update grunt-contrib-copy (Latest) * Update grunt-newer (Latest) * Replace grunt-ngmin with grunt-ng-annotate (Deprecated) * Update grunt-rev (Latest) * Update grunt-usemin (Latest) * Update jshint-stylish (Latest) * Update load-grunt-tasks (Latest) * Update time-grunt (Latest) * Update phantomjs (Last, replace with phantomjs-prebuilt for next versions) * Update package semver notation to prevent potential breaking of tooling * Update Bower components - Angular and modules to 1.5.x * Update Bower Angular components to 1.6.x - Change hrefs to hashbangs "#!" ($location hashPrefix default) * Update Bower Angular Components to 1.7.x * Remove unused Bower Components - angular-scenario (Deprecated since 1.7.x) - angular-mocks (karma used for tests) - axe-core (Outdated and never used) * Run npm audit fix - Fix mixin-deep - Fix set-value - Fix union-value * Update Bower Component Bootstrap (3.x) * Update test packages (Patch vulnerabilities) - Karma - grunt-karma - jasmine-core - karma-jasmine * Update node version for travis configuration * Revert remove unused Bower components (bfe9309) * Update package.lock * Update engine node version to >=v8-lts (8.15.0) * Update node version for travis configuration * Replace jshint with eslint * Update linters; - Remove jsHint linting from grunt configuration - Add node eslint linting script (lint:scripts) * Update linters; - Add stylelint for styles - Add nodescript to lint styles (Match editorconfig) * Update linters; - Change stylistic linting severity from error to warn; e.g. indentation (Fix true errors first) * Update stylelintrc; - Extend with standard config * Update ESlint configuration; - Change to .js file to add comments - Add rules to add more whitespace to code for readabillity. * Update stylelint configuration; - Add readabillity stylistic rules - Change to .js extension to add comments * Lint .eslintrc.js; (ignored by default) * Run eslint --fix * Run stylelint --fix * Update wcag2Spec tests; - Add empty lines for readability - Change abbreviations to full words for readability - Remove re-assignment of variables * Update wcag2spec test; - Change “getCriterion” test to test against new 2.1 id (text-equiv-all > non-text-content) * Update export test file; - Add whitespace, newlines and move comments for readability * Update export tests; - Change to test new context (version 3) * Add v3-data to dummydata for export test * Add new service; evalContextV3 (Add for test) * Update context version 3 to reflect WCAG 2.1 * Update evaluation model to use version 3 context (WCAG 2.1) * Add contextV3 provider to application index.html * Update test/import.js with eslint fixes & formatting * Update import test; - Replace dummydata v2 with v3 * Update import model; - Update with eslint fixes and formatting - Add / format jsdocs * Update evaluation explore model; - Change initial types from Array to undefined (commonPages, otherRelevantPages: non exported properties) * Update evaluation explore model; - Move commonPages and otherRelevantPages to basicProps (and exportable) * Update evaluation explore model; - Add readability (newlines) * Update version 1 data convertor; - Add assertion.testcase if-guard * Add readability to version 1 import conversion * Add clarification to exploreModel test * Update model migrations test; - Add readability - Update to reflect migrations up to latest models (Was fixed on version 2 context) * Update data migration to V3; - Update tests - Add updateToV3 to data migration and apply on V1 * Update explore model && controller with readability * Update evalContextV3 readability * Update Karma configuration; - Tidy - Add client configuration for jasmin * Update data migration tests; - Add a subtest to check if evaluation data is different between versions (after having used the updater to V2) * Update migration script (importV1); - Change upgradeToV2 to not modify imported evaluation * Add a wcagSpec Id version map to update to latest version * Update importV1; - Add version 2 check - Add version 3 check * Update migration importV1; - Add migration helpers for version 3 - Update version 1 auditResult to version 3 * Update v2-data test; auditmodel assertions are tested not dummydata * Add wcagSpecIdMap.js to index.html * Update importV1 script; - Add local helper _atLeastEqualTo to compare if object1 is an instanceof like object2 * Update importV1's isV1Evaluation with _atLeastEqualTo * Update importV1's isV2Evaluation with _atLeastEqualTo * Update import script; - Add isLatestVersion guard to the conversion and execute a step by step datamigration * Update evaluation/audit by commenting out criteria reset in import; (Added note for research / keeping an eye on reasoning) * Add examples to documentation; (Versioned exports json-ld to be used for testing and playing around) * Update v2-data test; (refinement to v3 data) * Add basic set of types; - Apply to CriterionAssert - Apply to TestCaseAssert - Apply to import conversion (Make sure types are added to model) * Update invalid V3 Dummydata with mode and result.type * Update types.js to use strict * Update success-criterion understanding and how to links * Update navigation resources context menu links * Fix missed hash to hashbang changes in hrefs * Update explore translateable relied_upon to add 2.1 * Update url references to resources * Update explore controller; - Add if guard before acting - Change input selection to first in list * Update import model; - Remove empty variable definition var testCallback and refactor to function declaration * Update import model compacted testCallback to return on errors * Update importV1; Remove futuristic if guard * Update context values to constants
- Add conditional view flow - Add filename and body on success to scope - Return to evaluation when done
(Allow json type files)
- Add actual file data with jsonld API
- Add initial validation, validating required assertion keys
- Add validation for required wcag relevance
- Add validation for required result outcome (Useless assertion without result)
- Re-add assertedBy as required
…wcag-earl-reports
(How it should look to be compatible)
(Build broke oops...)
* Add wcag version choice into step 1: scope view * Add wcag version label and info text to locale * Add wcag version to scope model and controller * Add wcag version to report scope * Add criteria version filter buttons to audit view * Fix mixed tab & spaces * Update version filtering, set initial values * Update criteria filterering, add version comparison * Remove wcagVersion from being exported (for now; requires adjustment to app context + data migration or just adjust test spec...)
Updated Logos
* Update navbar style small screens; remove branding padding * Update navbar style; Remove extra navbar- classes for better branding handling * Update navbar style big screens; Remove fixed positioning * Update navbar style @media; Remove resizing of images and navbar * Update navbar style @media; Remove border styling
…riterionIdSet (Issue w3c#324 secondary fix; stay forgiving)
Rename translation label for placeholder to group translations (w3c#328)
…ed-data' into develop
|
Hey @brunopulis , Thank you for your contribution! I will start reviewing your work shortly. |
rvantonisse
suggested changes
Mar 9, 2020
There was a problem hiding this comment.
If you could fix those format issues by running prettier with eslint that would be great.
Other than that, there are a few new additions to the translations since release 2.0.0 found in locale/EN files like:
- scope.json
- audit.json
- nav.json
- report.json
- import.json (new file)
If you could translate those as well that would be great.
Thank you again.
| @@ -0,0 +1,31 @@ | |||
| { | |||
There was a problem hiding this comment.
There seem to be some formatting issues here, please use the project's formatting configuration to fix these (editorconfig, eslint)
There was a problem hiding this comment.
OK, I will fix in the next commit
| @@ -0,0 +1,19 @@ | |||
| { | |||
There was a problem hiding this comment.
Same formatting issues
There was a problem hiding this comment.
OK, I will fix in the next commit
app/locale/PT/sample.json
Outdated
| "BTN_ADD_PAGE": "Adicionar nova página", | ||
| "BTN_REMOVE_PAGE": "Remover página", | ||
| "STRUCTURED_PAGE": "Página estruturada", | ||
| "RANDOM_PAGE": "Página aleatória", |
There was a problem hiding this comment.
Same formatting issues
There was a problem hiding this comment.
OK, I will fix in the next commit
app/locale/PT/scope.json
Outdated
| @@ -0,0 +1,22 @@ | |||
| { | |||
| "TITLE": "Etapa 1: definir o escopo da avaliação", | |||
| "INTRO": "Defina os parâmetros gerais e o escopo da avaliação. Idealmente, isso é feito com a pessoa que encomendou a avaliação (que pode ou não ser o proprietário do site), para garantir expectativas comuns sobre o escopo da avaliação. Mais orientações sobre esta etapa são fornecidas na <a href={{link_step1}}> Etapa 1 da WCAG-EM: definir o escopo da avaliação </a>. ", | |||
There was a problem hiding this comment.
Same, formatting issues
There was a problem hiding this comment.
OK, I will fix in the next commit
app/scripts/app.language.js
Outdated
| @@ -1,63 +1,68 @@ | |||
| 'use strict'; | |||
There was a problem hiding this comment.
OK, I will fix in the next commit
|
Hi @rvantonisse sorry my delay I will check all these recommendations :) |
|
Hello @rvantonisse, I think I did something wrong I went to update my fork with the original repository and several commits came. If it is not in the standard I can correct it. I'm sorry if I'm wrong I don't have much experience with github. |
|
Hey @brunopulis, Thank you for your work! I'll check it out and push it to the gh page for others to check it out. I will merge this to master as soon as I am ready with my translation fixes (see #333). |
rvantonisse
approved these changes
May 11, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The purpose of this PR is to add support for the Portuguese language for Portuguese speaking developers to take advantage of this tool.