Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add header and page components #1298

Merged
merged 3 commits into from
Nov 29, 2023
Merged

feat: add header and page components #1298

merged 3 commits into from
Nov 29, 2023

Conversation

anitavincent
Copy link
Contributor

@anitavincent anitavincent commented Nov 24, 2023

Summary

add header and page components

Examples

<Page>
      <Header>Header</Header>
      <Content className="page-content">
        <div className="page-inner-content">Page content</div>
      </Content>
</Page>

@anitavincent anitavincent requested a review from a team as a code owner November 24, 2023 14:24
Copy link

vercel bot commented Nov 24, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
shoreline-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 29, 2023 6:34pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
admin-ui-docs ⬜️ Ignored (Inspect) Nov 29, 2023 6:34pm

packages/components/src/header/header.css Outdated Show resolved Hide resolved
packages/components/src/header/header.tsx Outdated Show resolved Hide resolved
packages/components/src/header/header.tsx Show resolved Hide resolved
packages/components/src/page/stories/styles.css Outdated Show resolved Hide resolved
packages/components/src/header/stories/header.stories.tsx Outdated Show resolved Hide resolved
Comment on lines 2 to 4
import { Container } from '../content'

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
import { Container } from '../content'
import { Container } from '../content'
import './page.css'

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't css supposed to be imported by the user?

Copy link
Contributor

@matheusps matheusps Nov 29, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, the component css should be on the component. We changed it last week. This was the fix for storybook styling issues

packages/components/src/page/stories/page.stories.tsx Outdated Show resolved Hide resolved
packages/components/src/page/tests/page.vitest.test.tsx Outdated Show resolved Hide resolved
Copy link
Contributor

@matheusps matheusps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After the CSS import, LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants