Skip to content

Commit

Permalink
feat(modal): reuse general header
Browse files Browse the repository at this point in the history
  • Loading branch information
anitavincent committed Nov 29, 2023
1 parent 3b8efb2 commit 1996d7d
Show file tree
Hide file tree
Showing 6 changed files with 5 additions and 18 deletions.
1 change: 0 additions & 1 deletion packages/components/src/header/stories/header.stories.tsx
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
import '../header.css'
import './styles.css'
import React from 'react'

Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import React from 'react'
import { describe, expect, test } from 'vitest'
import { render } from '@testing-library/react'
import { describe, expect, test, render } from '@vtex/shoreline-test-utils'

import { Header } from '../header'

Expand All @@ -11,4 +10,3 @@ describe('header', () => {
expect(container.querySelector('[data-sl-header]')).toBeInTheDocument()
})
})

6 changes: 0 additions & 6 deletions packages/components/src/modal/modal-header.css

This file was deleted.

7 changes: 3 additions & 4 deletions packages/components/src/modal/modal-header.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -5,15 +5,14 @@ import { Flex } from '../flex'
import { IconButton } from '../icon-button'
import { IconX } from '@vtex/shoreline-icons'
import { Bleed } from '../bleed'
import { Content } from '../content'
import './modal-header.css'
import { Header } from '../header'

export const ModalHeader = forwardRef<HTMLDivElement, ModalHeaderProps>(
function Modal(props, ref) {
const { children, ...otherProps } = props

return (
<Content data-sl-modal-header narrow {...otherProps} ref={ref}>
<Header data-sl-modal-header narrow {...otherProps} ref={ref}>
<Flex justify="space-between">
<DialogHeading data-sl-modal-title>{children}</DialogHeading>
<Bleed vertical horizontal>
Expand All @@ -24,7 +23,7 @@ export const ModalHeader = forwardRef<HTMLDivElement, ModalHeaderProps>(
</IconButton>
</Bleed>
</Flex>
</Content>
</Header>
)
}
)
Expand Down
1 change: 0 additions & 1 deletion packages/components/src/page/stories/page.stories.tsx
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
import '../page.css'
import './styles.css'
import React from 'react'

Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import React from 'react'
import { describe, expect, test } from 'vitest'
import { render } from '@testing-library/react'
import { describe, expect, test, render } from '@vtex/shoreline-test-utils'

import { Page } from '../page'

Expand All @@ -11,4 +10,3 @@ describe('page', () => {
expect(container.querySelector('[data-sl-page]')).toBeInTheDocument()
})
})

0 comments on commit 1996d7d

Please sign in to comment.