Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Remove our special duckdb installing #73

Merged
merged 1 commit into from
Jun 1, 2022

Conversation

jonkeane
Copy link
Contributor

We've updated the way that duckdb gets used so that it is only needed to (re)create tpc-h data, and thus should be able to be installed only when that happens.

@jonkeane
Copy link
Contributor Author

@ElenaHenderson ElenaHenderson self-requested a review May 31, 2022 20:36
Copy link
Contributor

@ElenaHenderson ElenaHenderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this change and scheduling a test build!

@jonkeane
Copy link
Contributor Author

jonkeane commented Jun 1, 2022

Ok, looking at that build, there are two failures:

  • (1) tpc-h seems to be failing on validation (though this might be due to rounding | floating point precision?). I tried this out locally and could not reproduce (and the code I've altered in arrowbench has been running successfully for a while now on the actual benchmarks) So I think this is fine
  • (2) it looks like generating scale factor 10 data also failed — this isn't totally surprising if the machine running this test doesn't have a huge amount of memory. Maybe we should disable that test for this test build?
  • (3) micro c++ benchmarks failed — I'm not totally sure why, nothing I changed should impact them.

I suspect these issues are all from the test harness and not the change to the code — but would love a second opinion on that @ElenaHenderson

@ElenaHenderson
Copy link
Contributor

@jonkeane I am pretty confident that builds failures are not caused by the changes in this PR.

I created #74 to fix environment used for running arrow-bci-benchmark-build-test builds.

@ElenaHenderson ElenaHenderson merged commit 9b4521e into main Jun 1, 2022
@ElenaHenderson ElenaHenderson deleted the dont-preinstall-duckdb branch June 1, 2022 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants