Remove our special duckdb installing (#73)

voltrondata-labs · Jun 1, 2022 · 9b4521e · 9b4521e
1 parent ea4f403
commit 9b4521e
Show file tree

Hide file tree

Showing 4 changed files with 0 additions and 18 deletions.
diff --git a/buildkite/benchmark/run.py b/buildkite/benchmark/run.py
@@ -37,7 +37,6 @@
             "Python": ["create_data_dir"],
             "R": [
                 "build_arrow_r",
-                "install_duckdb_r_with_tpch",
                 "install_arrowbench",
                 "create_data_dir",
             ],

diff --git a/buildkite/benchmark/utils.sh b/buildkite/benchmark/utils.sh
@@ -106,21 +106,6 @@ install_arrowbench() {
   R -e "remotes::install_local('./arrowbench')"
 }
 
-install_duckdb_r_with_tpch() {
-  git clone https://github.com/duckdb/duckdb.git
-
-  # now fetch the latest tag to install
-  cd duckdb
-  git fetch --tags
-  latestTag=$(git describe --tags `git rev-list --tags --max-count=1`)
-  git checkout $latestTag
-
-  # and then do the install
-  cd tools/rpkg
-  R -e "remotes::install_deps()"
-  DUCKDB_R_EXTENSIONS=tpch R CMD INSTALL .
-}
-
 install_java_script_project_dependencies() {
   pushd $REPO_DIR
   source dev/conbench_envs/hooks.sh install_java_script_project_dependencies

diff --git a/docs/how-to-add-new-benchmarkable-repo.md b/docs/how-to-add-new-benchmarkable-repo.md
@@ -53,7 +53,6 @@ Examples of `benchmarks.json` in repos with benchmarks integrated with Conbench:
         "setup_commands_for_lang_benchmarks": {
             "R": [
                 "build_arrow_r",
-                "install_duckdb_r_with_tpch",
                 "install_arrowbench",
                 "create_data_dir",
             ]

diff --git a/tests/buildkite/benchmark/test_run_benchmarks.py b/tests/buildkite/benchmark/test_run_benchmarks.py
@@ -21,7 +21,6 @@
 
 expected_setup_commands_for_r_benchmarks = [
     ("source buildkite/benchmark/utils.sh build_arrow_r", ".", True),
-    ("source buildkite/benchmark/utils.sh install_duckdb_r_with_tpch", ".", True),
     ("source buildkite/benchmark/utils.sh install_arrowbench", ".", True),
     ("source buildkite/benchmark/utils.sh create_data_dir", ".", True),
 ]