Add capability to use RAP/HRRR MASSDEN as smoke IC/LBCs #923

jordanschnell · 2024-03-20T13:47:21Z

DESCRIPTION OF CHANGES:

Previously, massden/smoke was not part of the variable list to ingest into IC/LBCs from RAP/HRRR models. This PR adds the massden/smoke to the mapping table and adds the necessary functionality to read in and convert to the correct units. An additional allocated array is created when using RAP/HRRR for ICs/LBCs during the smoke read to be able to convert units. Other models (e.g., GFS) will not attempt to read in smoke.

TESTS CONDUCTED:

Compile branch on all Tier 1 machines using Intel (Orion, Jet, Hera, Hercules and WCOSS2).
Compile branch on Hera using GNU.
Compile branch in 'Debug' mode on WCOSS2 with no warnings. Done using f63fbbe.
Run unit tests locally on any Tier 1 machine. Done on WCOSS2 using f63fbbe.
Run chgres_cube consistency tests locally on all Tier 1 machines.

Additional tests performed.

Changes based on develop (72fb94f)
Compiled on CENTOS node on Jet
Created IC/BCs from RAP for RRFS 05/14/2023 00Z cycle using RAP cycle 05/13/2023 21Z.
@MichaelLueken - Successfully tested the branch within the SRW App. See Add capability to use RAP/HRRR MASSDEN as smoke IC/LBCs #923 (comment)
Doxygen was built with no warnings on WCOSS2 using f63fbbe.

DEPENDENCIES:

none

DOCUMENTATION:

Update readthedocs: https://noaa-emcufs-utils.readthedocs.io/en/latest/ufs_utils.html#variable-mapping-varmap-table

ISSUE:

Fixes #851.

CONTRIBUTORS:

Johana Romero-Alvarez (CIRES/NOAA GSL)

GeorgeGayno-NOAA · 2024-03-20T14:43:53Z

I am curious what project or implementation this PR supports.

jordanschnell · 2024-03-20T14:56:15Z

I am curious what project or implementation this PR supports.

I'm not sure exactly which details you need, but this is largely research oriented e.g., For computational efficiency, for retrospective experiments prior to RRFS-A SD implementation, we often only want to run the CONUS domain but would still like e.g., Canadian originated smoke to enter the domain (e.g., DRSA FIRE3). The same could be said for using HRRR IC/BCs for the fire nest. This wIll also support NOAA ERB funded work.

GeorgeGayno-NOAA · 2024-03-20T18:42:55Z

We ask that developers run the consistency tests located in ./reg_tests/chgres_cube. I ran them on Hera (CentOS nodes). Two of the tests failed. (The number of tracers in the gfs_ctrl.nc file differ from the baseline). Can you run these tests on Jet? Just invoke ./driver.jet.sh.

jordanschnell · 2024-03-20T18:44:47Z

We ask that developers run the consistency tests located in ./reg_tests/chgres_cube. I ran them on Hera (CentOS nodes). Two of the tests failed. (The number of tracers in the gfs_ctrl.nc file differ from the baseline). Can you run these tests on Jet? Just invoke ./driver.jet.sh.

Will do - and will look into these failures. Thank you for the information.

jordanschnell · 2024-03-20T20:41:44Z

We ask that developers run the consistency tests located in ./reg_tests/chgres_cube. I ran them on Hera (CentOS nodes). Two of the tests failed. (The number of tracers in the gfs_ctrl.nc file differ from the baseline). Can you run these tests on Jet? Just invoke ./driver.jet.sh.

I ran the tests on Jet and also received the two failures (13-km CONUS RAP W/ GSD PHYSICS AND SFC FROM FILE GRIB2 and 3-km CONUS HRRR W/ GSD PHYSICS AND SFC FROM FILE GRIB2). This makes sense though, since smoke is being added to the files and so e.g., there is an additional tracer in the out files. How would you like this to be addressed?

GeorgeGayno-NOAA · 2024-03-25T19:53:14Z

We ask that developers run the consistency tests located in ./reg_tests/chgres_cube. I ran them on Hera (CentOS nodes). Two of the tests failed. (The number of tracers in the gfs_ctrl.nc file differ from the baseline). Can you run these tests on Jet? Just invoke ./driver.jet.sh.

I ran the tests on Jet and also received the two failures (13-km CONUS RAP W/ GSD PHYSICS AND SFC FROM FILE GRIB2 and 3-km CONUS HRRR W/ GSD PHYSICS AND SFC FROM FILE GRIB2). This makes sense though, since smoke is being added to the files and so e.g., there is an additional tracer in the out files. How would you like this to be addressed?

The number of tracers in gfs_ctrl.nc should match those the in the atmospheric 'out' file.

GeorgeGayno-NOAA · 2024-03-25T19:58:29Z

As a test, I ran the 13km.conus.rap.grib2 regression test with all the smoke records removed from the input GRIB2 file.

The test script was updated as follows:

--- a/reg_tests/chgres_cube/13km.conus.rap.grib2.sh
+++ b/reg_tests/chgres_cube/13km.conus.rap.grib2.sh
@@ -16,9 +16,9 @@ export CRES=778
 export KMRES=13km
 export FIXfv3=${HOMEreg}/fix/RRFS_CONUS_${KMRES}

-export COMIN=${HOMEreg}/input_data/rap.grib2
+export COMIN=/work2/noaa/da/ggayno/save/UFS_UTILS.schnell/data

-export GRIB2_FILE_INPUT=1921221000900
+export GRIB2_FILE_INPUT=rap.grb2
 export VCOORD_FILE=${HOMEufs}/fix/am/global_hyblev.l64.txt
 export VARMAP_FILE=${HOMEufs}/parm/varmap_tables/GSDphys_var_map.txt

The modified input data and the script used to create it is here: /work2/noaa/da/ggayno/save/UFS_UTILS.schnell/data

jordanschnell · 2024-03-25T20:03:34Z

We ask that developers run the consistency tests located in ./reg_tests/chgres_cube. I ran them on Hera (CentOS nodes). Two of the tests failed. (The number of tracers in the gfs_ctrl.nc file differ from the baseline). Can you run these tests on Jet? Just invoke ./driver.jet.sh.

I ran the tests on Jet and also received the two failures (13-km CONUS RAP W/ GSD PHYSICS AND SFC FROM FILE GRIB2 and 3-km CONUS HRRR W/ GSD PHYSICS AND SFC FROM FILE GRIB2). This makes sense though, since smoke is being added to the files and so e.g., there is an additional tracer in the out files. How would you like this to be addressed?

The number of tracers in gfs_ctrl.nc should match those the in the atmospheric 'out' file.

But if the end result of my modifications is to add a new tracer to the out file, won't it automatically fail?

GeorgeGayno-NOAA · 2024-03-25T20:03:53Z

For the first test using the modified input data, I updated the varmap file as follows:

--- a/parm/varmap_tables/GSDphys_var_map.txt
+++ b/parm/varmap_tables/GSDphys_var_map.txt
@@ -25,4 +25,4 @@ icetk               icetk     set_to_fill   265.0     S
 weasd               weasd     set_to_fill   0.0       S
 snod                snod      set_to_fill   0.0       S
 tprcp               tprcp     set_to_fill   0.0       S
-massden             smoke     set_to_fill   1E-12     T
+massden             smoke     stop          1E-12     T

Since there are no smoke records, processing should stop. And that is what the log file shows:

- CALL FieldGather TEMPERATURE.
 - READ PRESSURE FOR SMOKE CONVERSION.
 - FATAL ERROR:
 READING massden at level      1 hybrid       . TO MAKE THIS NON-FATAL, CHANGE S
 TOP TO SKIP FOR THIS VARIABLE IN YOUR VARMAP FILE.
 - IOSTAT IS:            0
Abort(999) on node 0 (rank 0 in comm 0): application called MPI_Abort(MPI_COMM_WORLD, 999) - process 0

jordanschnell · 2024-03-25T20:04:26Z

As a test, I ran the 13km.conus.rap.grib2 regression test with all the smoke records removed from the input GRIB2 file.

The test script was updated as follows:
--- a/reg_tests/chgres_cube/13km.conus.rap.grib2.sh
+++ b/reg_tests/chgres_cube/13km.conus.rap.grib2.sh
@@ -16,9 +16,9 @@ export CRES=778
 export KMRES=13km
 export FIXfv3=${HOMEreg}/fix/RRFS_CONUS_${KMRES}

-export COMIN=${HOMEreg}/input_data/rap.grib2
+export COMIN=/work2/noaa/da/ggayno/save/UFS_UTILS.schnell/data

-export GRIB2_FILE_INPUT=1921221000900
+export GRIB2_FILE_INPUT=rap.grb2
 export VCOORD_FILE=${HOMEufs}/fix/am/global_hyblev.l64.txt
 export VARMAP_FILE=${HOMEufs}/parm/varmap_tables/GSDphys_var_map.txt
The modified input data and the script used to create it is here: /work2/noaa/da/ggayno/save/UFS_UTILS.schnell/data

I don't have access to this system. Are you suggesting I add something to the code? Or the reg test?

jordanschnell · 2024-03-25T20:05:53Z

For the first test using the modified input data, I updated the varmap file as follows:

--- a/parm/varmap_tables/GSDphys_var_map.txt
+++ b/parm/varmap_tables/GSDphys_var_map.txt
@@ -25,4 +25,4 @@ icetk               icetk     set_to_fill   265.0     S
 weasd               weasd     set_to_fill   0.0       S
 snod                snod      set_to_fill   0.0       S
 tprcp               tprcp     set_to_fill   0.0       S
-massden             smoke     set_to_fill   1E-12     T
+massden             smoke     stop          1E-12     T

Since there are no smoke records, processing should stop. And that is what the log file shows:

- CALL FieldGather TEMPERATURE.
 - READ PRESSURE FOR SMOKE CONVERSION.
 - FATAL ERROR:
 READING massden at level      1 hybrid       . TO MAKE THIS NON-FATAL, CHANGE S
 TOP TO SKIP FOR THIS VARIABLE IN YOUR VARMAP FILE.
 - IOSTAT IS:            0
Abort(999) on node 0 (rank 0 in comm 0): application called MPI_Abort(MPI_COMM_WORLD, 999) - process 0

Can you explain why you modified this?

GeorgeGayno-NOAA · 2024-03-25T20:20:10Z

For the first test using the modified input data, I updated the varmap file as follows:

--- a/parm/varmap_tables/GSDphys_var_map.txt
+++ b/parm/varmap_tables/GSDphys_var_map.txt
@@ -25,4 +25,4 @@ icetk               icetk     set_to_fill   265.0     S
 weasd               weasd     set_to_fill   0.0       S
 snod                snod      set_to_fill   0.0       S
 tprcp               tprcp     set_to_fill   0.0       S
-massden             smoke     set_to_fill   1E-12     T
+massden             smoke     stop          1E-12     T

Since there are no smoke records, processing should stop. And that is what the log file shows:

- CALL FieldGather TEMPERATURE.
 - READ PRESSURE FOR SMOKE CONVERSION.
 - FATAL ERROR:
 READING massden at level      1 hybrid       . TO MAKE THIS NON-FATAL, CHANGE S
 TOP TO SKIP FOR THIS VARIABLE IN YOUR VARMAP FILE.
 - IOSTAT IS:            0
Abort(999) on node 0 (rank 0 in comm 0): application called MPI_Abort(MPI_COMM_WORLD, 999) - process 0

Can you explain why you modified this?

The varmap files have several choices with how to process fields:

For the first test using the modified input data, I updated the varmap file as follows:

--- a/parm/varmap_tables/GSDphys_var_map.txt
+++ b/parm/varmap_tables/GSDphys_var_map.txt
@@ -25,4 +25,4 @@ icetk               icetk     set_to_fill   265.0     S
 weasd               weasd     set_to_fill   0.0       S
 snod                snod      set_to_fill   0.0       S
 tprcp               tprcp     set_to_fill   0.0       S
-massden             smoke     set_to_fill   1E-12     T
+massden             smoke     stop          1E-12     T

Since there are no smoke records, processing should stop. And that is what the log file shows:

- CALL FieldGather TEMPERATURE.
 - READ PRESSURE FOR SMOKE CONVERSION.
 - FATAL ERROR:
 READING massden at level      1 hybrid       . TO MAKE THIS NON-FATAL, CHANGE S
 TOP TO SKIP FOR THIS VARIABLE IN YOUR VARMAP FILE.
 - IOSTAT IS:            0
Abort(999) on node 0 (rank 0 in comm 0): application called MPI_Abort(MPI_COMM_WORLD, 999) - process 0

Can you explain why you modified this?

According to the README file, users can adjust how fields are processed using the varmap file. (See the instructions for column 3). Options include 'stop', 'skip' 'set_to_fill' etc. These different options need to be tested. So, I am temporarily modifying the varmap file.

https://github.com/ufs-community/UFS_UTILS/blob/develop/parm/varmap_tables/README

GeorgeGayno-NOAA · 2024-03-26T12:59:49Z

Next, test the 'skip' function. Modify the varmap table as follows:

--- a/parm/varmap_tables/GSDphys_var_map.txt
+++ b/parm/varmap_tables/GSDphys_var_map.txt
@@ -25,4 +25,4 @@ icetk               icetk     set_to_fill   265.0     S
 weasd               weasd     set_to_fill   0.0       S
 snod                snod      set_to_fill   0.0       S
 tprcp               tprcp     set_to_fill   0.0       S
-massden             smoke     set_to_fill   1E-12     T
+massden             smoke     skip          1E-12     T

The log file shows:

WARNING: SKIPPING massden IN FILE
WARNING: SKIPPING massden IN FILE
WARNING: SKIPPING massden IN FILE

And the out.atm.tile7.nc file contains a smoke record. Because the input GRIB2 file does not contain smoke, that was unexpected. According to the README, when 'skip' is used, there should not be a smoke record.

Herc /work2/noaa/stmp/ggayno/reg-tests/chgres-cube.skip/13km_conus_rap_grib2\ $ ncdump -h out.atm.tile7.nc
        float ice_aero(lev, lat, lon) ;
                ice_aero:coordinates = "geolon geolat" ;
        float sgs_tke(lev, lat, lon) ;
                sgs_tke:coordinates = "geolon geolat" ;
        float smoke(lev, lat, lon) ;
                smoke:coordinates = "geolon geolat" ;
        float u_w(lev, lat, lonp) ;
                u_w:coordinates = "geolon_w geolat_w" ;

@LarissaReames-NOAA and @JeffBeck-NOAA - you understand the GRIB2 option better I do. What is the expected result in this case?

GeorgeGayno-NOAA · 2024-07-29T12:40:01Z

@jordanschnell - this PR has not been updated in a while. There is more work required if you want to merge it. What do you want to do?

jordanschnell · 2024-08-06T18:08:57Z

@GeorgeGayno-NOAA - We would like to merge it, however, I was not sure what else is required. Your question to Jeff and Larissa went unanswered and I am unsure of what the issue is. It seems like there may be other issues though (#851)

LarissaReames-NOAA · 2024-08-06T20:54:37Z

I think what @jordanschnell needs to do is create his own var mapping file based on the GSD var mapping file he's tested with. I don't think we should be modifying a file we've long used in the current form, especially when this doesn't reflect some operational change. This way there won't be any failures in the regression tests either.

How you'd choose the option for missing variables really depends. We never implemented any behavior to not write an array to file if "skip" is chosen and the variable is unavailable in the grib2 file. I believe the philosophy was always that, given a certain weather model SDF, we always wanted the atm init files to have certain arrays in them regardless of what data is available in the grib2 files used to create them. If I remember correctly, we use "skip" for those variables that might be missing data at certain levels, like RH in some GFS grib2 files, so that a few missing levels wouldn't cause a failure. If you plan on a variable possible being completely missing from a grib2 file but don't want that to cause a failure, I'd suggest using set_to_fill.

So, in that sort of paradigm, one might expect any weather model run utilizing HRRR Smoke to also require its own unique SDF, so it would make sense to have a separate variable mapping file. In that mapping file you could indeed set the missing behavior to be "stop" to make sure a user is initializing that weather model SDF with all the desired smoke tracers.

…from the original varmap

jordanschnell · 2024-10-02T20:00:39Z

@LarissaReames-NOAA @GeorgeGayno-NOAA I have created a separate varmap file that contains smoke and removed smoke from the original file. To use, the varmap file in make_ics/make_lbcs scripts needs to be set to the new file. Please let me know if you would like further modifications.

GeorgeGayno-NOAA · 2024-10-03T19:51:37Z

@jordanschnell - be sure to merge updates from develop to your branch.

jordanschnell · 2024-10-03T20:03:43Z

@jordanschnell - be sure to merge updates from develop to your branch.

@GeorgeGayno-NOAA, is that just:

git checkout rap_icbc
git merge develop

Then do I need to git push?

GeorgeGayno-NOAA · 2024-10-03T20:14:59Z

@jordanschnell - be sure to merge updates from develop to your branch.

@GeorgeGayno-NOAA, is that just:

git checkout rap_icbc git merge develop

Then do I need to git push?

That will work if 'develop' in your fork is up-to-date with the authoritative fork. See our wiki page for how I do it (last two bullets).

https://github.com/ufs-community/UFS_UTILS/wiki/3.-Checking-out-code-and-making-changes

I like to do things from the command line. But, I would guess you can also do these updates from the web browser.

GeorgeGayno-NOAA · 2024-10-04T12:45:29Z

@GeorgeGayno-NOAA I received an error:

here were my commands:

and branches:
From the browser, would I "Sync fork"?

Don't clone using 'http', instead use, for example: [email protected]:ufs-community/UFS_UTILS.git

DavidHuber-NOAA

The math works out. Thanks @jordanschnell!

MichaelLueken · 2024-10-04T20:25:57Z

@GeorgeGayno-NOAA -

The SRW-SD WE2E test successfully passed:

----------------------------------------------------------------------------------------------------
Experiment name                                                  | Status    | Core hours used
----------------------------------------------------------------------------------------------------
smoke_dust_grid_RRFS_CONUS_3km_suite_HRRR_gf_20241004134527        COMPLETE            1746.09
----------------------------------------------------------------------------------------------------
Total                                                              COMPLETE            1746.09

I can also confirm that the smoke data from the ICs/LBCs were read into the weather model:

Smoke is being set to a value other than default (1E-12) -
smoke 5.4751575E-02 7.9282990E-04 8.9739502E-04

The fundamental WE2E tests were also run and all passed:

----------------------------------------------------------------------------------------------------
Experiment name                                                  | Status    | Core hours used 
----------------------------------------------------------------------------------------------------
grid_RRFS_CONUScompact_25km_ics_HRRR_lbcs_RAP_suite_RRFS_v1beta_2  COMPLETE              11.56
grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v15p2_20241  COMPLETE               9.03
grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v17_p8_plot  COMPLETE              25.11
grid_RRFS_CONUScompact_25km_ics_HRRR_lbcs_HRRR_suite_HRRR_2024100  COMPLETE              43.06
grid_SUBCONUS_Ind_3km_ics_HRRR_lbcs_RAP_suite_WoFS_v0_20241004171  COMPLETE              26.77
grid_RRFS_CONUS_25km_ics_NAM_lbcs_NAM_suite_GFS_v16_2024100417143  COMPLETE              43.47
----------------------------------------------------------------------------------------------------
Total                                                              COMPLETE             159.00

With the original changes in GSDphys_var_map.txt, the grid_RRFS_CONUScompact_25km_ics_HRRR_lbcs_HRRR_suite_HRRR fundamental test failed. This indicates that the test is pulling the unaltered GSDphys_var_map.txt file and successfully running.

The comprehensive WE2E tests have also successfully passed without issue.

This update is running correctly in the SRW App.

jordanschnell · 2024-10-07T14:27:48Z

@GeorgeGayno-NOAA @DavidHuber-NOAA my develop is now up to date. Thank you for the help!

GeorgeGayno-NOAA · 2024-10-11T20:41:45Z

@GeorgeGayno-NOAA @DavidHuber-NOAA my develop is now up to date. Thank you for the help!

Great. Now, merge the updates from 'develop' to your branch. See bottom of this page:
https://github.com/ufs-community/UFS_UTILS/wiki/3.-Checking-out-code-and-making-changes

jordanschnell · 2024-10-11T21:01:09Z

@GeorgeGayno-NOAA I think I was successful

GeorgeGayno-NOAA · 2024-10-15T20:08:25Z

@jordanschnell - do you have simple case that I can convert into a regression test? The test would be added here:
https://github.com/ufs-community/UFS_UTILS/tree/develop/reg_tests/chgres_cube

jordanschnell · 2024-10-15T20:14:13Z

@jordanschnell - do you have simple case that I can convert into a regression test? The test would be added here: https://github.com/ufs-community/UFS_UTILS/tree/develop/reg_tests/chgres_cube

I think this one could be duplicated: reg_tests/chgres_cube/13km.conus.rap.grib2.sh

The only change needed would be the varmap.

GeorgeGayno-NOAA · 2024-10-16T12:32:09Z

@jordanschnell - do you have simple case that I can convert into a regression test? The test would be added here: https://github.com/ufs-community/UFS_UTILS/tree/develop/reg_tests/chgres_cube

I think this one could be duplicated: reg_tests/chgres_cube/13km.conus.rap.grib2.sh

The only change needed would be the varmap.

Can you try to create the test and run it from the driver script for your machine (I will help)? Does it need different input GRIB data from the 13km.conus.rap.grib2.sh test? I can add the input data to the baseline directory.

jordanschnell · 2024-10-16T14:08:40Z

@jordanschnell - do you have simple case that I can convert into a regression test? The test would be added here: https://github.com/ufs-community/UFS_UTILS/tree/develop/reg_tests/chgres_cube

I think this one could be duplicated: reg_tests/chgres_cube/13km.conus.rap.grib2.sh
The only change needed would be the varmap.

Can you try to create the test and run it from the driver script for your machine (I will help)? Does it need different input GRIB data from the 13km.conus.rap.grib2.sh test? I can add the input data to the baseline directory.

smoke/massden is in the grib2 input data so it can be used. I'll set it up and let you know if I have issues.

jordanschnell · 2024-10-16T14:18:28Z

@jordanschnell - do you have simple case that I can convert into a regression test? The test would be added here: https://github.com/ufs-community/UFS_UTILS/tree/develop/reg_tests/chgres_cube

I think this one could be duplicated: reg_tests/chgres_cube/13km.conus.rap.grib2.sh
The only change needed would be the varmap.

Can you try to create the test and run it from the driver script for your machine (I will help)? Does it need different input GRIB data from the 13km.conus.rap.grib2.sh test? I can add the input data to the baseline directory.

smoke/massden is in the grib2 input data so it can be used. I'll set it up and let you know if I have issues.

I guess, before I do, is it necessary to create basically the exact same regression test?

GeorgeGayno-NOAA · 2024-10-16T14:55:33Z

I made one change to the 13km.conus.rap.grib2 test:

diff --git a/reg_tests/chgres_cube/13km.conus.rap.grib2.sh b/reg_tests/chgres_cube/13km.conus.rap.grib2.sh
index 4da2468d..c0338b12 100755
--- a/reg_tests/chgres_cube/13km.conus.rap.grib2.sh
+++ b/reg_tests/chgres_cube/13km.conus.rap.grib2.sh
@@ -20,7 +20,7 @@ export COMIN=${HOMEreg}/input_data/rap.grib2

 export GRIB2_FILE_INPUT=1921221000900
 export VCOORD_FILE=${HOMEufs}/fix/am/global_hyblev.l64.txt
-export VARMAP_FILE=${HOMEufs}/parm/varmap_tables/GSDphys_var_map.txt
+export VARMAP_FILE=${HOMEufs}/parm/varmap_tables/GSDphys_smoke_var_map.txt
 export INPUT_TYPE='grib2'
 export CONVERT_NST=".false."

It ran to completion, and I see a smoke record in the output. Would this be a valid test? If so, make a copy of the 13km.conus.rap.grib2.sh script, give it a descriptive name, then add its call from the driver script. Try it on one machine first. Check the output. If it is correct, I will add it to the baseline directory.

jordanschnell · 2024-10-16T15:51:21Z

Smoke is in the output (/lfs5/BMC/rtwbl/rap-chem/tmp/regtest_out/reg-tests/chgres-cube/13km_conus_rap-smoke_grib2), but the regtest failed because it is not in the baseline.

GeorgeGayno-NOAA · 2024-10-17T14:22:35Z

Smoke is in the output (/lfs5/BMC/rtwbl/rap-chem/tmp/regtest_out/reg-tests/chgres-cube/13km_conus_rap-smoke_grib2), but the regtest failed because it is not in the baseline.

I created a baseline directory. Update the 13km.conus.rap-smoke.grib2.sh script as follows and try again:

diff --git a/reg_tests/chgres_cube/13km.conus.rap-smoke.grib2.sh b/reg_tests/chgres_cube/13km.conus.rap-smoke.grib2.sh
index e80e0579..2a7bfa19 100755
--- a/reg_tests/chgres_cube/13km.conus.rap-smoke.grib2.sh
+++ b/reg_tests/chgres_cube/13km.conus.rap-smoke.grib2.sh
@@ -81,7 +81,7 @@ for files in *.nc
 do
   if [ -f $files ]; then
     echo CHECK $files
-    $NCCMP -dmfqS $files $HOMEreg/baseline_data/13km_conus_rap_grib2/$files
+    $NCCMP -dmfqS $files $HOMEreg/baseline_data/13km_conus_rap-smoke_grib2/$files
     iret=$?
     if [ $iret -ne 0 ]; then

GeorgeGayno-NOAA · 2024-10-17T17:22:50Z

I created baseline directories on all Tier 1 machines.

jordanschnell · 2024-10-17T21:50:19Z

regression test: passed: /mnt/lfs5/BMC/rtwbl/rap-chem/src/RRFS/rrfs-workflow_rap_icbc_regtest/sorc/UFS_UTILS/reg_tests/chgres_cube/consistency.log14

GeorgeGayno-NOAA · 2024-10-18T12:16:57Z

regression test: passed: /mnt/lfs5/BMC/rtwbl/rap-chem/src/RRFS/rrfs-workflow_rap_icbc_regtest/sorc/UFS_UTILS/reg_tests/chgres_cube/consistency.log14

Great. Do you have access to the other Tier 1 machines? Hera, Orion, Hercules and WCOSS2? If not, I can update the driver scripts on those machines and run the tests.

reg_tests/chgres_cube/13km.conus.rap-smoke.grib2.sh

GeorgeGayno-NOAA · 2024-10-18T13:20:58Z

Because you are adding a varmap file, this section of the documentation may need some updates:
https://noaa-emcufs-utils.readthedocs.io/en/latest/ufs_utils.html#variable-mapping-varmap-table

I can help with that.

jordanschnell · 2024-10-18T16:43:13Z

@GeorgeGayno-NOAA I have access to Hera, but not the others. so, these are my remaining tasks?

Update driver.hera script and test there?
Add comments to regtest
Add documentation

GeorgeGayno-NOAA · 2024-10-18T17:09:10Z

@GeorgeGayno-NOAA I have access to Hera, but not the others. so, these are my remaining tasks?

Update driver.hera script and test there?

Add comments to regtest

Add documentation

And do as many of the tests described above in "TESTS CONDUCTED". I can do the tests on the Herc, Orion and WCOSS2.

jordanschnell · 2024-10-21T15:30:51Z

Regtest on Hera passed: /scratch1/BMC/wrf-chem/Jordan/RRFS-SD/src/PRs/rap_icbc/rrfs-workflow/sorc/UFS_UTILS/reg_tests/chgres_cube/consistency.log14

GeorgeGayno-NOAA · 2024-10-21T19:08:13Z

@jordanschnell - I updated and tested the regression test driver scripts on Hercules, Orion and WCOSS2. I placed them on Hera here: /scratch1/NCEPDEV/da/George.Gayno/ufs_utils.git/UFS_UTILS.schnell/reg_tests/chgres_cube

They have ".updated" in their filename.

jordanschnell · 2024-10-21T19:19:16Z

@jordanschnell - I updated and tested the regression test driver scripts on Hercules, Orion and WCOSS2. I placed them on Hera here: /scratch1/NCEPDEV/da/George.Gayno/ufs_utils.git/UFS_UTILS.schnell/reg_tests/chgres_cube

They have ".updated" in their filename.

Great thank you! So commit these?

GeorgeGayno-NOAA · 2024-10-21T19:21:58Z

@jordanschnell - I updated and tested the regression test driver scripts on Hercules, Orion and WCOSS2. I placed them on Hera here: /scratch1/NCEPDEV/da/George.Gayno/ufs_utils.git/UFS_UTILS.schnell/reg_tests/chgres_cube
They have ".updated" in their filename.

Great thank you! So commit these?

Yes.

jordanschnell added 6 commits March 19, 2024 16:12

Add capability to ingest RAP/HRRR smoke for IC/BC

3f9edb2

deallocate dummy3d_pres if allocated

a513d29

Fix typos

f3a0cdc

Explicit read of pressure during smoke portion of loop

047e3f1

cleanup

9273b88

Fix character length in massden

8704aa4

GeorgeGayno-NOAA mentioned this pull request Mar 22, 2024

Add smoke density from RAP files as an optional output from chgres #851

Open

GeorgeGayno-NOAA self-requested a review March 25, 2024 19:47

MichaelLueken mentioned this pull request Sep 9, 2024

[develop] Add smoke and dust capability ufs-community/ufs-srweather-app#1127

Open

24 tasks

Created seperate file that contains smoke variable and removed smoke …

fb62769

…from the original varmap

DavidHuber-NOAA approved these changes Oct 4, 2024

View reviewed changes

Merge branch 'ufs-community:develop' into rap_icbc

27cea32

jordanschnell added 2 commits October 16, 2024 15:40

add regtests for smoke

89db7a9

update reg

f63fbbe

GeorgeGayno-NOAA reviewed Oct 18, 2024

View reviewed changes

reg_tests/chgres_cube/13km.conus.rap-smoke.grib2.sh Outdated Show resolved Hide resolved

add hera regtest

a4de98b

Update drivers for hercules, wcoss2, and orion

0a954d1

Add capability to use RAP/HRRR MASSDEN as smoke IC/LBCs #923

Are you sure you want to change the base?

Add capability to use RAP/HRRR MASSDEN as smoke IC/LBCs #923

Conversation

jordanschnell commented Mar 20, 2024 • edited by GeorgeGayno-NOAA Loading

DESCRIPTION OF CHANGES:

TESTS CONDUCTED:

DEPENDENCIES:

DOCUMENTATION:

ISSUE:

CONTRIBUTORS:

GeorgeGayno-NOAA commented Mar 20, 2024

jordanschnell commented Mar 20, 2024

GeorgeGayno-NOAA commented Mar 20, 2024

jordanschnell commented Mar 20, 2024

jordanschnell commented Mar 20, 2024 • edited Loading

GeorgeGayno-NOAA commented Mar 25, 2024

GeorgeGayno-NOAA commented Mar 25, 2024

jordanschnell commented Mar 25, 2024

GeorgeGayno-NOAA commented Mar 25, 2024

jordanschnell commented Mar 25, 2024

jordanschnell commented Mar 25, 2024

GeorgeGayno-NOAA commented Mar 25, 2024

GeorgeGayno-NOAA commented Mar 26, 2024

GeorgeGayno-NOAA commented Jul 29, 2024

jordanschnell commented Aug 6, 2024

LarissaReames-NOAA commented Aug 6, 2024

jordanschnell commented Oct 2, 2024

GeorgeGayno-NOAA commented Oct 3, 2024

jordanschnell commented Oct 3, 2024

GeorgeGayno-NOAA commented Oct 3, 2024

GeorgeGayno-NOAA commented Oct 4, 2024

DavidHuber-NOAA left a comment

Choose a reason for hiding this comment

MichaelLueken commented Oct 4, 2024

jordanschnell commented Oct 7, 2024

GeorgeGayno-NOAA commented Oct 11, 2024

jordanschnell commented Oct 11, 2024

GeorgeGayno-NOAA commented Oct 15, 2024

jordanschnell commented Oct 15, 2024

GeorgeGayno-NOAA commented Oct 16, 2024

jordanschnell commented Oct 16, 2024

jordanschnell commented Oct 16, 2024

GeorgeGayno-NOAA commented Oct 16, 2024

jordanschnell commented Oct 16, 2024

GeorgeGayno-NOAA commented Oct 17, 2024

GeorgeGayno-NOAA commented Oct 17, 2024

jordanschnell commented Oct 17, 2024

GeorgeGayno-NOAA commented Oct 18, 2024

GeorgeGayno-NOAA commented Oct 18, 2024

jordanschnell commented Oct 18, 2024

GeorgeGayno-NOAA commented Oct 18, 2024

jordanschnell commented Oct 21, 2024

GeorgeGayno-NOAA commented Oct 21, 2024

jordanschnell commented Oct 21, 2024

GeorgeGayno-NOAA commented Oct 21, 2024

jordanschnell commented Mar 20, 2024 •

edited by GeorgeGayno-NOAA

Loading

jordanschnell commented Mar 20, 2024 •

edited

Loading