-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Manual fixes for CRAN #195
Conversation
@@ -45,7 +45,7 @@ The 'colours' component is a vector of fill colours to be used for the rectangle | |||
} | |||
\value{Returns an grob representing the legend(s)} | |||
\author{Lauren Chong} | |||
\seealso{\code{\link{create.heatmap}}, \code{\link{draw.key}}, \code{\link{gpar}}} | |||
\seealso{\code{\link{create.heatmap}}, \code{\link[lattice]{draw.key}}, \code{\link{gpar}}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does this \code{\link{gpar}}
have to be \code{\link[grid]{gpar}}
? ordo we not need to do that for base R stuff?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does this
\code{\link{gpar}}
have to be\code{\link[grid]{gpar}}
? ordo we not need to do that for base R stuff?
I thought about that! I think that's the case, or something along those lines. R CMD check only had a problem with lattice - not grid. It may also be that gpar
is used in the NAMESPACE, so it can automatically resolve.
Should be good once it passes R-CMD-check |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but there are a lot of warnings in the R CMD CHECK
: https://github.com/uclahs-cds/package-BoutrosLab-plotting-general/actions/runs/11152316111/job/30997684755
These are both false positives and unrelated to the changes in this PR. |
Description
Fixes two NOTEs in R CMD check.
Checklist
This PR does NOT contain PHI or germline genetic data. A repo may need to be deleted if such data is uploaded. Disclosing PHI is a major problem.
This PR does NOT contain molecular files, compressed files, output files such as images (e.g.
.png
, .jpeg
),.pdf
,.RData
,.xlsx
,.doc
,.ppt
, or other non-plain-text files. To automatically exclude such files using a .gitignore file, see here for example.I have read the code review guidelines and the code review best practice on GitHub check-list.
I have set up or verified the
main
branch protection rule following the github standards before opening this pull request.The name of the branch is meaningful and well formatted following the standards, using [AD_username (or 5 letters of AD if AD is too long)]-[brief_description_of_branch].
I have added the major changes included in this pull request to the
NEWS
under the next release version or unreleased, and updated the date. I have also updated the version number inDESCRIPTION
according to semantic versioning rules.Both
R CMD build
andR CMD check
run successfully.