Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manual fixes for CRAN #195

Merged
merged 4 commits into from
Oct 3, 2024
Merged

Manual fixes for CRAN #195

merged 4 commits into from
Oct 3, 2024

Conversation

dan-knight
Copy link
Contributor

Description

Fixes two NOTEs in R CMD check.

Rd file 'create.scatterplot.Rd':
  \examples lines wider than 100 characters:
         # "s" connects points with the vertical segment first. "S" connects points with the horizontal segment first.

These lines will be truncated in the PDF manual.
* checking Rd cross-references ... NOTE
Found the following Rd file(s) with Rd \link{} targets missing package
anchors:
  legend.grob.Rd: draw.key
Please provide package anchors for all Rd \link{} targets not in the

Checklist

  • This PR does NOT contain PHI or germline genetic data. A repo may need to be deleted if such data is uploaded. Disclosing PHI is a major problem.

  • This PR does NOT contain molecular files, compressed files, output files such as images (e.g. .png, .jpeg), .pdf, .RData, .xlsx, .doc, .ppt, or other non-plain-text files. To automatically exclude such files using a .gitignore file, see here for example.

  • I have read the code review guidelines and the code review best practice on GitHub check-list.

  • I have set up or verified the main branch protection rule following the github standards before opening this pull request.

  • The name of the branch is meaningful and well formatted following the standards, using [AD_username (or 5 letters of AD if AD is too long)]-[brief_description_of_branch].

  • I have added the major changes included in this pull request to the NEWS under the next release version or unreleased, and updated the date. I have also updated the version number in DESCRIPTION according to semantic versioning rules.

  • Both R CMD build and R CMD check run successfully.

@dan-knight dan-knight requested a review from jarbet October 2, 2024 21:43
@dan-knight dan-knight requested a review from a team as a code owner October 2, 2024 21:43
@@ -45,7 +45,7 @@ The 'colours' component is a vector of fill colours to be used for the rectangle
}
\value{Returns an grob representing the legend(s)}
\author{Lauren Chong}
\seealso{\code{\link{create.heatmap}}, \code{\link{draw.key}}, \code{\link{gpar}}}
\seealso{\code{\link{create.heatmap}}, \code{\link[lattice]{draw.key}}, \code{\link{gpar}}}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this \code{\link{gpar}} have to be \code{\link[grid]{gpar}}? ordo we not need to do that for base R stuff?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this \code{\link{gpar}} have to be \code{\link[grid]{gpar}}? ordo we not need to do that for base R stuff?

I thought about that! I think that's the case, or something along those lines. R CMD check only had a problem with lattice - not grid. It may also be that gpar is used in the NAMESPACE, so it can automatically resolve.

@whelena
Copy link

whelena commented Oct 2, 2024

Should be good once it passes R-CMD-check

Copy link
Contributor

@jarbet jarbet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dan-knight
Copy link
Contributor Author

There are a lot of warnings in the R CMD CHECK

These are both false positives and unrelated to the changes in this PR.

@dan-knight dan-knight merged commit bf44ecb into main Oct 3, 2024
5 of 6 checks passed
@dan-knight dan-knight deleted the danknight-man-fixes branch October 3, 2024 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants