Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: multiplatform support #283

Merged
merged 1 commit into from
Aug 21, 2024
Merged

fix: multiplatform support #283

merged 1 commit into from
Aug 21, 2024

Conversation

hhio618
Copy link
Contributor

@hhio618 hhio618 commented Aug 21, 2024

Resolves #282

@hhio618 hhio618 requested a review from Keyrxng as a code owner August 21, 2024 09:09
gitcoindev
gitcoindev approved these changes Aug 21, 2024
View reviewed changes
Copy link
Contributor

@gitcoindev gitcoindev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks clean to me. fsWriteFileSync is cross platform and automatically creates the file if it doesn’t exist or overwrites the existing file. Using cat assumed *nix.

0x4007
0x4007 approved these changes Aug 21, 2024
View reviewed changes
Copy link
Member

@0x4007 0x4007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to use type script instead of the shell

@ubiquity-os-deployer
Copy link

@github-actions GitHub Actions
Copy link
Contributor

Preview Deployment
fcc9b8d803f6c740c6d8156067720fb6fcc8bcf4

@Keyrxng
Copy link
Member

Keyrxng commented Aug 21, 2024 •
edited
Loading

fcc9b8d

This workflow failed earlier because it hit a secondary rate limit...

As expected builds fine now

@Keyrxng Keyrxng merged commit 1ae7280 into ubiquity:development Aug 21, 2024
3 checks passed
@ubiquity-os ubiquity-os bot mentioned this pull request Aug 21, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0x4007 0x4007 0x4007 approved these changes

@gitcoindev gitcoindev gitcoindev approved these changes

@Keyrxng Keyrxng Awaiting requested review from Keyrxng Keyrxng is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix build on non Unix platforms
4 participants
@hhio618 @Keyrxng @0x4007 @gitcoindev