Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build on non Unix platforms #282

Closed
gentlementlegen opened this issue Aug 21, 2024 · 3 comments · Fixed by #283
Closed

Fix build on non Unix platforms #282

gentlementlegen opened this issue Aug 21, 2024 · 3 comments · Fixed by #283

Comments

@gentlementlegen
Copy link
Member

          This broke builds on Windows (sorry if I am the only hipster here). `cat` command is only Unix compliant. I'd suggest using cross platform commands or directly Node which is sure to run on any platform. Guilty code:

execSync(`cat static/styles/rewards/pay.css > static/bundles/bundles.css`);

Originally posted by @gentlementlegen in #278 (comment)

@hhio618
Copy link
Contributor

hhio618 commented Aug 21, 2024

/start

Copy link
Contributor

ubiquity-os bot commented Aug 21, 2024

DeadlineWed, Aug 21, 6:25 PM UTC
Registered Wallet 0x6321286F9B73f427C72e1f9F1bC6b3d25eF06605
Tips:
  • Use /wallet 0x0000...0000 if you want to update your registered payment wallet address.
  • Be sure to open a draft pull request as soon as possible to communicate updates on your progress.
  • Be sure to provide timely updates to us when requested, or you will be automatically unassigned from the task.

Copy link
Contributor

ubiquity-os bot commented Aug 21, 2024

[ 25 WXDAI ]

@hhio618
Contributions Overview
View Contribution Count Reward
Issue Task 1 25
Review Comment 1 0
Conversation Incentives
Comment Formatting Relevance Reward
Resolves #282 <!-- - You must link the issue number e.g. "…
0
content:
  p:
    count: 3
    score: 1
  ul:
    count: 18
    score: 0
  li:
    count: 18
    score: 1
wordValue: 0
formattingMultiplier: 0
0.3 -

[ 13.8 WXDAI ]

@gentlementlegen
Contributions Overview
View Contribution Count Reward
Issue Specification 1 13.8
Conversation Incentives
Comment Formatting Relevance Reward
This broke builds on Windows (sorry if I am the only hipster her…
13.8
content:
  p:
    count: 45
    score: 1
  code:
    count: 1
    score: 1
  em:
    count: 6
    score: 0
wordValue: 0.1
formattingMultiplier: 3
1 13.8

[ 0.675 WXDAI ]

@gitcoindev
Contributions Overview
View Contribution Count Reward
Review Comment 1 0.675
Conversation Incentives
Comment Formatting Relevance Reward
Looks clean to me. fsWriteFileSync is cross platform and automat…
0.675
content:
  p:
    count: 26
    score: 1
  code:
    count: 1
    score: 1
wordValue: 0.1
formattingMultiplier: 0.25
1 0.675

[ 1 WXDAI ]

@0x4007
Contributions Overview
View Contribution Count Reward
Review Comment 1 1
Conversation Incentives
Comment Formatting Relevance Reward
Makes sense to use type script instead of the shell
1
content:
  p:
    count: 10
    score: 1
wordValue: 0.1
formattingMultiplier: 1
1 1

[ 1.6 WXDAI ]

@Keyrxng
Contributions Overview
View Contribution Count Reward
Review Comment 1 1.6
Conversation Incentives
Comment Formatting Relevance Reward
This workflow failed earlier because it hit a secondary rate lim…
1.6
content:
  p:
    count: 16
    score: 1
wordValue: 0.1
formattingMultiplier: 1
1 1.6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants