Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Exercise1: Unit Test for Keangnam Beer #12

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 36 additions & 0 deletions UnitTestTraining.xcodeproj/project.pbxproj
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,11 @@
17BBD8AB252B159E003535D1 /* APIUrls.swift in Sources */ = {isa = PBXBuildFile; fileRef = 17BBD8AA252B159E003535D1 /* APIUrls.swift */; };
17BBD8B4252B1950003535D1 /* ArticleCell.swift in Sources */ = {isa = PBXBuildFile; fileRef = 17BBD8B2252B1950003535D1 /* ArticleCell.swift */; };
17BBD8B5252B1950003535D1 /* ArticleCell.xib in Resources */ = {isa = PBXBuildFile; fileRef = 17BBD8B3252B1950003535D1 /* ArticleCell.xib */; };
3CBAC3EF2834885D00B6E4FC /* Exercise1ViewModelTests.swift in Sources */ = {isa = PBXBuildFile; fileRef = 3CBAC3EE2834885D00B6E4FC /* Exercise1ViewModelTests.swift */; };
3CBAC3F12834887500B6E4FC /* Exercise1ControllerTests.swift in Sources */ = {isa = PBXBuildFile; fileRef = 3CBAC3F02834887500B6E4FC /* Exercise1ControllerTests.swift */; };
3CBAC3F32834888C00B6E4FC /* Exercise1UseCaseMock.swift in Sources */ = {isa = PBXBuildFile; fileRef = 3CBAC3F22834888C00B6E4FC /* Exercise1UseCaseMock.swift */; };
3CBAC3F5283488AC00B6E4FC /* Exercise1NavigatorMock.swift in Sources */ = {isa = PBXBuildFile; fileRef = 3CBAC3F4283488AC00B6E4FC /* Exercise1NavigatorMock.swift */; };
3CBAC3F828348DA100B6E4FC /* CalculateBeerPriceTests.swift in Sources */ = {isa = PBXBuildFile; fileRef = 3CBAC3F728348DA100B6E4FC /* CalculateBeerPriceTests.swift */; };
5297A24C250B27A1002745A9 /* Exercise3ViewController.swift in Sources */ = {isa = PBXBuildFile; fileRef = 5297A247250B27A0002745A9 /* Exercise3ViewController.swift */; };
5297A24D250B27A1002745A9 /* Exercise3ViewModel.swift in Sources */ = {isa = PBXBuildFile; fileRef = 5297A248250B27A0002745A9 /* Exercise3ViewModel.swift */; };
5297A24E250B27A1002745A9 /* Exercise3Navigator.swift in Sources */ = {isa = PBXBuildFile; fileRef = 5297A249250B27A1002745A9 /* Exercise3Navigator.swift */; };
Expand Down Expand Up @@ -289,6 +294,11 @@
17BBD8AA252B159E003535D1 /* APIUrls.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = APIUrls.swift; sourceTree = "<group>"; };
17BBD8B2252B1950003535D1 /* ArticleCell.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = ArticleCell.swift; sourceTree = "<group>"; };
17BBD8B3252B1950003535D1 /* ArticleCell.xib */ = {isa = PBXFileReference; lastKnownFileType = file.xib; path = ArticleCell.xib; sourceTree = "<group>"; };
3CBAC3EE2834885D00B6E4FC /* Exercise1ViewModelTests.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = Exercise1ViewModelTests.swift; sourceTree = "<group>"; };
3CBAC3F02834887500B6E4FC /* Exercise1ControllerTests.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = Exercise1ControllerTests.swift; sourceTree = "<group>"; };
3CBAC3F22834888C00B6E4FC /* Exercise1UseCaseMock.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = Exercise1UseCaseMock.swift; sourceTree = "<group>"; };
3CBAC3F4283488AC00B6E4FC /* Exercise1NavigatorMock.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = Exercise1NavigatorMock.swift; sourceTree = "<group>"; };
3CBAC3F728348DA100B6E4FC /* CalculateBeerPriceTests.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = CalculateBeerPriceTests.swift; sourceTree = "<group>"; };
5297A247250B27A0002745A9 /* Exercise3ViewController.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = Exercise3ViewController.swift; sourceTree = "<group>"; };
5297A248250B27A0002745A9 /* Exercise3ViewModel.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = Exercise3ViewModel.swift; sourceTree = "<group>"; };
5297A249250B27A1002745A9 /* Exercise3Navigator.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = Exercise3Navigator.swift; sourceTree = "<group>"; };
Expand Down Expand Up @@ -684,6 +694,7 @@
children = (
177763EE261E8BE3005CC014 /* TestError.swift */,
177763EF261E8BE3005CC014 /* App */,
3CBAC3ED283487FB00B6E4FC /* Exercise1 */,
177763F8261E8BE4005CC014 /* Exercise2 */,
177763FD261E8BE4005CC014 /* Exercise3 */,
17776425261E8BE4005CC014 /* Main */,
Expand Down Expand Up @@ -765,6 +776,7 @@
isa = PBXGroup;
children = (
17776437261E8BE4005CC014 /* GettingExercisesTests.swift */,
3CBAC3F628348CDE00B6E4FC /* Exercise1 */,
1777643A261E8BE4005CC014 /* Exercise2 */,
1777643C261E8BE4005CC014 /* Exercise3 */,
);
Expand Down Expand Up @@ -880,6 +892,25 @@
path = Base;
sourceTree = "<group>";
};
3CBAC3ED283487FB00B6E4FC /* Exercise1 */ = {
isa = PBXGroup;
children = (
3CBAC3EE2834885D00B6E4FC /* Exercise1ViewModelTests.swift */,
3CBAC3F02834887500B6E4FC /* Exercise1ControllerTests.swift */,
3CBAC3F22834888C00B6E4FC /* Exercise1UseCaseMock.swift */,
3CBAC3F4283488AC00B6E4FC /* Exercise1NavigatorMock.swift */,
);
path = Exercise1;
sourceTree = "<group>";
};
3CBAC3F628348CDE00B6E4FC /* Exercise1 */ = {
isa = PBXGroup;
children = (
3CBAC3F728348DA100B6E4FC /* CalculateBeerPriceTests.swift */,
);
path = Exercise1;
sourceTree = "<group>";
};
5297A246250B2772002745A9 /* Exercise3 */ = {
isa = PBXGroup;
children = (
Expand Down Expand Up @@ -1263,9 +1294,13 @@
17776486261E8BE4005CC014 /* ExerciseGatewayMock.swift in Sources */,
1777645D261E8BE4005CC014 /* Exercise3ViewControllerTests.swift in Sources */,
17776451261E8BE4005CC014 /* AppViewModelTests.swift in Sources */,
3CBAC3F12834887500B6E4FC /* Exercise1ControllerTests.swift in Sources */,
17776458261E8BE4005CC014 /* Exercise2ViewModelTests.swift in Sources */,
3CBAC3F5283488AC00B6E4FC /* Exercise1NavigatorMock.swift in Sources */,
1777648B261E8BE4005CC014 /* CaculatingClotherDiscountTest.swift in Sources */,
3CBAC3EF2834885D00B6E4FC /* Exercise1ViewModelTests.swift in Sources */,
1777647D261E8BE4005CC014 /* MainViewControllerTests.swift in Sources */,
3CBAC3F32834888C00B6E4FC /* Exercise1UseCaseMock.swift in Sources */,
1777645F261E8BE4005CC014 /* Exercise3UseCaseMock.swift in Sources */,
17776452261E8BE4005CC014 /* AppUseCaseMock.swift in Sources */,
17776450261E8BE4005CC014 /* TestError.swift in Sources */,
Expand All @@ -1278,6 +1313,7 @@
17776453261E8BE4005CC014 /* AppNavigatorMock.swift in Sources */,
17776459261E8BE4005CC014 /* Exercise2ViewControllerTests.swift in Sources */,
17776487261E8BE4005CC014 /* DateGatewayMock.swift in Sources */,
3CBAC3F828348DA100B6E4FC /* CalculateBeerPriceTests.swift in Sources */,
1777645B261E8BE4005CC014 /* Exercise2NavigatorMock.swift in Sources */,
1777645E261E8BE4005CC014 /* Exercise3ViewModelTests.swift in Sources */,
);
Expand Down
7 changes: 7 additions & 0 deletions UnitTestTraining/Support/Extensions/Date+.swift
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,13 @@ extension Date {
return DayInWeek(rawValue: calendar.dateComponents([.weekday], from: self).weekday ?? 0) ?? .none
}

static func createDayWith(string: String) -> Date {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
static func createDayWith(string: String) -> Date {
static func createDayWith(string: String) -> Date? {

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hàm này có trả về default là Date() rồi ạ

let formatter = DateFormatter()
formatter.dateFormat = "yyyy/MM/dd HH:mm:ss"
formatter.timeZone = TimeZone(secondsFromGMT: 7)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

secondsFromGMT, tính theo 7 giây thì có vẻ sai nhỉ, phải là 7 giờ chứ

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Đang tính theo giờ đó anh, Exercise2 cũng viết func này. Em chỉ copy ra extension để dùng thôi.

return formatter.date(from: string) ?? Date()
}

enum DayInWeek: Int {
case none = 0
case sunday
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,41 @@
//
// CalculateBeerPriceTests.swift
// UnitTestTrainingTests
//
// Created by truong.quoc.bao on 18/05/2022.
// Copyright © 2022 Sun Asterisk. All rights reserved.
//

import XCTest
@testable import UnitTestTraining

class CalculateBeerPriceTests: XCTestCase, CalculatingBeerPrice {

override func setUp() {
super.setUp()
}

func test_useVoucher() {
let dto = BeerOrderDto(usingVoucher: true, purchaseTime: Date())
let result = self.calculateBeerPrice(dto: dto)

XCTAssertEqual(result, 100)
}

func test_notUseVoucher_inPromotionTime() {
let date = Date(hour: 17) ?? Date() // Date.createDayWith(string: "2022/05/18 10:10:00") // 17:10:00 // +7
let dto = BeerOrderDto(usingVoucher: false, purchaseTime: date)
let result = self.calculateBeerPrice(dto: dto)

XCTAssertEqual(result, 290)
}

func test_notUseVoucher_notInPromotionTime() {
let date = Date(hour: 18) ?? Date()
let dto = BeerOrderDto(usingVoucher: false, purchaseTime: date)
let result = self.calculateBeerPrice(dto: dto)

XCTAssertEqual(result, 490)
}

}
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
//
// Exercise1ControllerTests.swift
// UnitTestTrainingTests
//
// Created by truong.quoc.bao on 18/05/2022.
// Copyright © 2022 Sun Asterisk. All rights reserved.
//

import XCTest
@testable import UnitTestTraining

final class Exercise1ControllerTests: XCTestCase {

var viewController: Exercise1ViewController!

override func setUp() {
super.setUp()
viewController = Exercise1ViewController.instantiate()
}

func test_ibOutlets() {
_ = viewController.view
XCTAssertNotNil(viewController.voucherSwitch)
XCTAssertNotNil(viewController.purchaseDatePicker)
XCTAssertNotNil(viewController.priceLabel)

}

}
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
//
// Exercise1NavigatorMock.swift
// UnitTestTrainingTests
//
// Created by truong.quoc.bao on 18/05/2022.
// Copyright © 2022 Sun Asterisk. All rights reserved.
//

import XCTest
@testable import UnitTestTraining

final class Exercise1NavigatorMock: Exercise1NavigatorType {

}
22 changes: 22 additions & 0 deletions UnitTestTrainingTests/Scenes/Exercise1/Exercise1UseCaseMock.swift
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
//
// Exercise1UseCaseMock.swift
// UnitTestTrainingTests
//
// Created by truong.quoc.bao on 18/05/2022.
// Copyright © 2022 Sun Asterisk. All rights reserved.
//

import XCTest
@testable import UnitTestTraining

final class Exercise1UseCaseMock: Exercise1UseCaseType {

var calculateBeerPriceCalled = false
var calculateBeerPriceValue = 0.0

func calculateBeerPrice(dto: BeerOrderDto) -> Double {
calculateBeerPriceCalled = true
return calculateBeerPriceValue
}

}
Original file line number Diff line number Diff line change
@@ -0,0 +1,71 @@
//
// Exercise1ViewModelTests.swift
// UnitTestTrainingTests
//
// Created by truong.quoc.bao on 18/05/2022.
// Copyright © 2022 Sun Asterisk. All rights reserved.
//

import XCTest
import RxSwift
import RxCocoa
@testable import UnitTestTraining

final class Exercise1ViewModelTests: XCTestCase {

private var viewModel: Exercise1ViewModel!
private var navigator: Exercise1NavigatorMock!
private var useCase: Exercise1UseCaseMock!

private var input: Exercise1ViewModel.Input!
private var output: Exercise1ViewModel.Output!

private var disposeBag: DisposeBag!

private let loadTrigger = PublishSubject<Void>()
private let voucherTrigger = BehaviorRelay<Bool>(value: false)
private let purchaseTimeTrigger = BehaviorRelay<Date>(value: Date())

override func setUp() {
super.setUp()

disposeBag = DisposeBag()

navigator = Exercise1NavigatorMock()
useCase = Exercise1UseCaseMock()
viewModel = Exercise1ViewModel(navigator: navigator, useCase: useCase)

input = Exercise1ViewModel.Input(
loadTrigger: loadTrigger.asDriverOnErrorJustComplete(),
voucherTrigger: voucherTrigger.asDriver(),
purchaseTimeTrigger: purchaseTimeTrigger.asDriver()
)

output = viewModel.transform(input, disposeBag: disposeBag)
}

func test_loadTriggerInvoked_calculateBeerPrice() {
self.useCase.calculateBeerPriceValue = 490.0
loadTrigger.onNext(())

XCTAssert(self.useCase.calculateBeerPriceCalled)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thêm dòng kiểm tra output.price
vd: XCTAssertEqual(output.price, (490.0).japanCurrency)

XCTAssertEqual(output.price, (490.0).japanCurrency)
}

func test_voucherTriggerInvoked_calculateBeerPrice() {
self.useCase.calculateBeerPriceValue = 100.0
voucherTrigger.accept(true)

XCTAssert(self.useCase.calculateBeerPriceCalled)
XCTAssertEqual(output.price, (100.0).japanCurrency)
}

func test_purchaseTimeTriggerInvoked_calculateBeerPrice() {
self.useCase.calculateBeerPriceValue = 290.0
purchaseTimeTrigger.accept(Date())

XCTAssert(self.useCase.calculateBeerPriceCalled)
XCTAssertEqual(output.price, (290.0).japanCurrency)
}
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thiếu test:

  • test_voucherTrigger_calculateBeerPrice
  • test_promotionTimeTrigger_calculateBeerPrice


}