WIP: Exercise1: Unit Test for Keangnam Beer #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tuanta-0175
reviewed
May 18, 2022
| static func createDayWith(string: String) -> Date { | ||
| let formatter = DateFormatter() | ||
| formatter.dateFormat = "yyyy/MM/dd HH:mm:ss" | ||
| formatter.timeZone = TimeZone(secondsFromGMT: 7) |
There was a problem hiding this comment.
secondsFromGMT, tính theo 7 giây thì có vẻ sai nhỉ, phải là 7 giờ chứ
There was a problem hiding this comment.
Đang tính theo giờ đó anh, Exercise2 cũng viết func này. Em chỉ copy ra extension để dùng thôi.
| @@ -20,6 +20,13 @@ extension Date { | |||
| return DayInWeek(rawValue: calendar.dateComponents([.weekday], from: self).weekday ?? 0) ?? .none | |||
| } | |||
|
|
|||
| static func createDayWith(string: String) -> Date { | |||
There was a problem hiding this comment.
Suggested change
| static func createDayWith(string: String) -> Date { | |
| static func createDayWith(string: String) -> Date? { |
There was a problem hiding this comment.
Hàm này có trả về default là Date() rồi ạ
| } | ||
|
|
||
| func test_notUseVoucher_inPromotionTime() { | ||
| let date = Date.createDayWith(string: "2022/05/18 10:10:00") // 17:10:00 // +7 |
| func test_calculateBeerPrice() { | ||
| loadTrigger.onNext(()) | ||
|
|
||
| XCTAssert(self.useCase.calculateBeerPriceCalled) |
There was a problem hiding this comment.
thêm dòng kiểm tra output.price
vd: XCTAssertEqual(output.price, (490.0).japanCurrency)
tuanta-0175
reviewed
May 18, 2022
| loadTrigger.onNext(()) | ||
|
|
||
| XCTAssert(self.useCase.calculateBeerPriceCalled) | ||
| } |
There was a problem hiding this comment.
thiếu test:
- test_voucherTrigger_calculateBeerPrice
- test_promotionTimeTrigger_calculateBeerPrice
|
LGTM! |
Exercise1: Unit Test for Keangnam Beer
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.