Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APPENG-849] Fix prometheus client cant cast metric type gauge to info issue #86

Merged
merged 1 commit into from
Jul 25, 2024
Merged

[APPENG-849] Fix prometheus client cant cast metric type gauge to info issue #86

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,10 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [0.29.1] 2024-07-25
### Fixed
- Fixed the prometheus metrics cant cast metric type gauge to info issue.

## [0.29.0] - 2024-07-16

### Added
Expand Down
2 changes: 1 addition & 1 deletion gradle.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
version=0.29.0
version=0.29.1
4 changes: 3 additions & 1 deletion tw-tkms-starter/src/main/java/com/transferwise/kafka/tkms/metrics/TkmsMetricsTemplate.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,9 @@
@Slf4j
public class TkmsMetricsTemplate implements ITkmsMetricsTemplate, InitializingBean {

public static final String GAUGE_LIBRARY_INFO = "tw_library_info";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But is it going to create issues with older version of SB?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, now that I think about it, it should not

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't look like it, already tested with 3.2 as well.

Micrometer has been supporting both underscore and dot.

This one looks more like a bug from their end cuz even now they support underscore just that this doesn't get properly converted to an info type.

// Miccrometer 1.13 (which comes with Spring boot 3.3) doesn't properly convert gauge metrics with info suffix when using underscore,
// using dot here as a workaround
public static final String GAUGE_LIBRARY_INFO = "tw.library.info";
public static final String TIMER_PROXY_POLL = "tw_tkms_proxy_poll";
public static final String GAUGE_PROXY_POLL_IN_PROGRESS = "tw_tkms_proxy_poll_in_progress";
public static final String TIMER_PROXY_CYCLE = "tw_tkms_proxy_cycle";
Expand Down
Loading