[APPENG-849] Fix prometheus client cant cast metric type gauge to info issue #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tw-peeterkarolin
approved these changes
Jul 25, 2024
xSeagullx
reviewed
Jul 25, 2024
| @@ -34,7 +34,9 @@ | |||
| @Slf4j | |||
| public class TkmsMetricsTemplate implements ITkmsMetricsTemplate, InitializingBean { | |||
|
|
|||
| public static final String GAUGE_LIBRARY_INFO = "tw_library_info"; | |||
There was a problem hiding this comment.
But is it going to create issues with older version of SB?
There was a problem hiding this comment.
Actually, now that I think about it, it should not
There was a problem hiding this comment.
Doesn't look like it, already tested with 3.2 as well.
Micrometer has been supporting both underscore and dot.
This one looks more like a bug from their end cuz even now they support underscore just that this doesn't get properly converted to an info type.
xSeagullx
approved these changes
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This pull request attempts to fix the micrometer prometheus metrics cant cast metric type gauge to info issue by using dot based format as a workaround.
Checklist
Details from ticket: APPENG-849
Update platform libraries matrix tests to run with boot 3.3