Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strings2factors #1376

Merged
merged 7 commits into from
Oct 1, 2024
Merged

Strings2factors #1376

merged 7 commits into from
Oct 1, 2024

Conversation

dajmcdon
Copy link
Contributor

This is a possible fix for #1358 .

  • Adds a small function that undoes the results of get_levels() for any columns that do not have the roles "outcome" or "predictor".
  • By "undoes", it simply gives those columns the same result that would happen for continuous variables list(values = NA, ordered = NA)

Sorry for the annoying whitespace changes. I think there's only a few.

Copy link
Member

@EmilHvitfeldt EmilHvitfeldt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good so far. Can you also add a bullet to the news file and document this change in behavior for prep.recipe()? thank you

R/misc.R Outdated Show resolved Hide resolved
@EmilHvitfeldt
Copy link
Member

I also ran a revdepcheck on this PR and nothing bad happened

@EmilHvitfeldt
Copy link
Member

Looks good! thank you for doing this!

@EmilHvitfeldt EmilHvitfeldt merged commit 104d30d into tidymodels:main Oct 1, 2024
11 checks passed
Copy link

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions bot locked and limited conversation to collaborators Oct 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants