Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

recipes:::strings2factors should be restricted by the role #1358

Closed
dajmcdon opened this issue Aug 12, 2024 · 2 comments
Closed

recipes:::strings2factors should be restricted by the role #1358

dajmcdon opened this issue Aug 12, 2024 · 2 comments
Labels
feature a feature request or enhancement

Comments

@dajmcdon
Copy link
Contributor

dajmcdon commented Aug 12, 2024

Feature

prep.recipe() calls recipes:::strings2factors() to convert character columns to factors (when true). It would be better if this operated, not on all columns but only on those with certain roles (likely just predictors + outcomes).

Context: I'm working on an extension that would accommodate panel data. This involves keeping around a key column which needs to remain a character regardless of the decisions for predictor columns.

I'm happy to do a PR for this if it would be helpful. I think it requires only minor changes, but hopefully would cause few downstream issues.

@EmilHvitfeldt EmilHvitfeldt added the feature a feature request or enhancement label Aug 15, 2024
@EmilHvitfeldt
Copy link
Member

I think that sounds reasonable. If you feel like it, feel free to start the PR 😄

@dajmcdon
Copy link
Contributor Author

dajmcdon commented Oct 8, 2024

Closed by #1376

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature a feature request or enhancement
Projects
None yet
Development

No branches or pull requests

2 participants