Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(dom-testing-library): Update Keyboard events example code #869

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

docs(dom-testing-library): Update Keyboard events example code #869

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions docs/dom-testing-library/api-events.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,9 +91,9 @@ fireEvent.drop(getByLabelText(/drop files here/i), {
element in the DOM and the key you want to fire.

```javascript
fireEvent.keyDown(domNode, { key: 'Enter', code: 'Enter' })
fireEvent.keyDown(domNode, { key: 'Enter', code: 'Enter', charCode: 13 })
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the feedback. I dont' think we want to document deprecated event properties though (https://developer.mozilla.org/en-US/docs/Web/API/KeyboardEvent/charCode). Is the charCode important here for any framework?


fireEvent.keyDown(domNode, { key: 'A', code: 'KeyA' })
fireEvent.keyDown(domNode, { key: 'A', code: 'KeyA', charCode: 65 })
```

You can find out which key code to use at
Expand Down