Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(dom-testing-library): Update Keyboard events example code #869

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sarahgabrielle
Copy link

Change

  • Update Keyboard events example code to include charCode in the event properties object - this update relates to issue 269

Update Keyboard events example code to include ```charCode``` in the event properties object
@sarahgabrielle sarahgabrielle changed the title Update api-events.mdx docs(dom-testing-library): Update Keyboard events example code Jun 25, 2021
@@ -91,9 +91,9 @@ fireEvent.drop(getByLabelText(/drop files here/i), {
element in the DOM and the key you want to fire.

```javascript
fireEvent.keyDown(domNode, { key: 'Enter', code: 'Enter' })
fireEvent.keyDown(domNode, { key: 'Enter', code: 'Enter', charCode: 13 })
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the feedback. I dont' think we want to document deprecated event properties though (https://developer.mozilla.org/en-US/docs/Web/API/KeyboardEvent/charCode). Is the charCode important here for any framework?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants