-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add some missing nuclides from nuclides.dat #1903
base: main
Are you sure you want to change the base?
Conversation
@john-science just a heads up. This should be pretty simple to push through. I can handle internal QA-related things. I've pinged @jakehader and Connor for an SME review. |
@albeanth Can you run the big internal suite of unit tests against this PR? Obviously, functionally, this PR shouldn't make a big difference. But I imagine some "diffs" popping up in your internal integration tests, and who knows maybe someone is checking an exact number in their unit tests somewhere. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two lines don't look right to me. Please double check.
line 2914 now is 70 171 188 0 should be -> 70 118 188 0
line 3092 now is 73 120 195 0 should be -> 73 122 195 0
Additionally, it's good to add the source of these added lines, and modify the sentence at the beginning of the file "This file contains a set of 4614 nuclides and their associated metadata" 4614 -> 4624
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The added nuclides data look good to me.
I can verify but not validate this change. Holler when you guys want to merge this. |
What is the change?
A simple change to add some nuclides to nuclides.dat to support downstream analysis.
Why is the change being made?
It's good to account for all the nuclides that one might care about.
Checklist
doc
folder.pyproject.toml
.