Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow client to suggest delay until next retry #334

Merged
merged 1 commit into from
Jan 3, 2024
Merged

Allow client to suggest delay until next retry #334

merged 1 commit into from
Jan 3, 2024

Conversation

ast2023
Copy link
Contributor

@ast2023 ast2023 commented Dec 5, 2023 •
edited by alexshtin
Loading

What changed?
retry_after field was added to RespondActivityTaskFailedRequest message.

Why?
Activity should be able to specify retry interval.

Breaking changes
No.

@ast2023 ast2023 requested review from a team as code owners December 5, 2023 19:51
bergundy
bergundy reviewed Dec 5, 2023
View reviewed changes
Copy link
Member

@bergundy bergundy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, left a single comment.

@ast2023 ast2023 force-pushed the sasha/OSS-1858 branch 3 times, most recently from a106d32 to 0c3cbf0 Compare December 5, 2023 20:10
@cretz cretz mentioned this pull request Dec 11, 2023
Merged
Sushisource
Sushisource approved these changes Dec 11, 2023
View reviewed changes
Copy link
Member

@Sushisource Sushisource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me

temporal/api/common/v1/message.proto Outdated Show resolved Hide resolved
temporal/api/workflowservice/v1/request_response.proto Outdated Show resolved Hide resolved
@ast2023 ast2023 changed the title Allow client to suggest delay until next retry Allow client to suggest delay until next retry. Jan 2, 2024
@ast2023 ast2023 changed the title Allow client to suggest delay until next retry. Allow client to suggest delay until next retry Jan 2, 2024
alexshtin
alexshtin approved these changes Jan 2, 2024
View reviewed changes
Copy link
Member

@alexshtin alexshtin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After number of different attempts I saw here, and bunch of discussions, I believe this is the best way to do it.

@ast2023 ast2023 merged commit 59df52a into master Jan 3, 2024
4 checks passed
@ast2023 ast2023 deleted the sasha/OSS-1858 branch January 3, 2024 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexshtin alexshtin alexshtin approved these changes

@bergundy bergundy Awaiting requested review from bergundy

@cretz cretz Awaiting requested review from cretz

@Sushisource Sushisource Awaiting requested review from Sushisource

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ast2023 @bergundy @cretz @Sushisource @alexshtin