Allow client to suggest delay until next retry #1319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ast2023
commented
Dec 8, 2023
bergundy
reviewed
Dec 8, 2023
cretz
reviewed
Dec 13, 2023
bergundy
reviewed
Dec 13, 2023
ast2023
force-pushed
the
sasha/OSS-1858
branch
from
c180126
to
07f31b0
Compare
cretz
reviewed
Dec 13, 2023
ast2023
force-pushed
the
sasha/OSS-1858
branch
3 times, most recently
from
d5e4f14
to
fcf630e
Compare
ast2023
force-pushed
the
sasha/OSS-1858
branch
from
fcf630e
to
44773e2
Compare
ast2023
requested review from
cretz,
Quinn-With-Two-Ns,
Sushisource and
bergundy
cretz
reviewed
Jan 10, 2024
# Conflicts: # go.mod # internal/cmd/build/go.mod
cretz
reviewed
Jan 22, 2024
bergundy
reviewed
Jan 22, 2024
cretz
reviewed
Jan 22, 2024
| @@ -523,6 +548,8 @@ func (e *ApplicationError) Unwrap() error { | |||
| return e.cause | |||
| } | |||
|
|
|||
| func (e *ApplicationError) NextRetryDelay() time.Duration { return e.nextRetryDelay } | |||
There was a problem hiding this comment.
Should have godoc, but not that big of a deal.
There was a problem hiding this comment.
I am failing to find documentation which will explain NextRetryDelay better than the name of the method.
There was a problem hiding this comment.
Godoc rules often stipulate Godoc for all exported items regardless of obviousness (yes that means usually if redundant). Granted we don't have such a strict requirement, but we usually follow it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
A new error type was introduced, which allows requesting next retry interval from an activity.
Why?
Allow developers to adjust retry interval on specific errors.
Checklist
Closes 1858
How was this tested:
Created a workflow/activity. Activity would return the new error with the retry interval. Verified that the value was received by the server.
Any docs updates needed?
The new error should be documented in the developer's guide.