Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(apidom-parser-adapter-openapi-json-3-0): remove rc version support #4320

Merged
merged 1 commit into from
Aug 16, 2024

Conversation

rainum
Copy link
Contributor

@rainum rainum commented Aug 16, 2024

This PR removes rc version support from apidom-parser-adapter-openapi-json-3-0 package.

Description

This PR does the following:

  • modifies version detection RegExp
  • adds one additional test to ensure that rc releases are not recognized anymore

Motivation and Context

Closes #2265

How Has This Been Tested?

It has been tested by adding new unit tests in the package folder.

Checklist

My PR contains...

  • No code changes (src/ is unmodified: changes to documentation, CI, metadata, etc.)
  • Dependency changes (any modification to dependencies in package.json)
  • Bug fixes (non-breaking change which fixes an issue)
  • Improvements (misc. changes to existing features)
  • Features (non-breaking change which adds functionality)

My changes...

  • are breaking changes to a public API (config options, System API, major UI change, etc).
  • are breaking changes to a private API (Redux, component props, utility functions, etc.).
  • are breaking changes to a developer API (npm script behavior changes, new dev system dependencies, etc).
  • are not breaking changes.

Documentation

  • My changes do not require a change to the project documentation.
  • My changes require a change to the project documentation.
  • If yes to above: I have updated the documentation accordingly.

Automated tests

  • My changes can not or do not need to be tested.
  • My changes can and should be tested by unit and/or integration tests.
  • If yes to above: I have added tests to cover my changes.
  • If yes to above: I have taken care to cover edge cases in my tests.
  • All new and existing tests passed.

@rainum rainum requested a review from char0n August 16, 2024 09:43
@rainum rainum self-assigned this Aug 16, 2024
@rainum rainum force-pushed the bug/remove-rc-version-support branch from 8a22e90 to 06b1afb Compare August 16, 2024 09:51
@rainum rainum changed the title bug(apidom-parser-adapter-openapi-json-3-0): remove rc version support fix(apidom-parser-adapter-openapi-json-3-0): remove rc version support Aug 16, 2024
@rainum rainum force-pushed the bug/remove-rc-version-support branch from 06b1afb to a39026d Compare August 16, 2024 09:59
Copy link
Member

@char0n char0n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Thank you!

@char0n char0n added enhancement New feature or request ApiDOM OpenApi 3.0 labels Aug 16, 2024
@char0n
Copy link
Member

char0n commented Aug 16, 2024

@rainum can you during the sqash+merge do reference the issue in the commit msg footer?

fix(apidom-parser-adapter-openapi-json-3-0): remove rc version support

Refs #2265 

@rainum rainum merged commit b8afa76 into main Aug 16, 2024
8 checks passed
@rainum rainum deleted the bug/remove-rc-version-support branch August 16, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OpenAPI 3.0.x parser adapters - remove ability to recognize RC versions of the spec
2 participants