Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenAPI 3.0.x parser adapters - remove ability to recognize RC versions of the spec #2265

Closed
char0n opened this issue Nov 9, 2022 · 2 comments · Fixed by #4320
Closed

OpenAPI 3.0.x parser adapters - remove ability to recognize RC versions of the spec #2265

char0n opened this issue Nov 9, 2022 · 2 comments · Fixed by #4320
Assignees
Labels

Comments

@char0n
Copy link
Member

char0n commented Nov 9, 2022

OpenAPI 3.0.x adapter still recognize RC versions, but non of the other tooling does. This can create inconsistencies that might lead to future errors. The scope of this issue to remove support in OpenAPI 3.0.x parser adapters to recognize RC versions of OpenAPI 3.0.x spec.

@char0n
Copy link
Member Author

char0n commented Aug 15, 2024

This is related to OpenAPI 3.0.x parser adapter recognizing rc versions of OpenAPI 3.0.x spec -

export const detectionRegExp = /"openapi"\s*:\s*"(?<version_json>3\.0\.([0123])(?:-rc[012])?)"/;

Technically if we remove the explicit rc handling from regex, nothing really changes as the regex is inclusive. We don't even support media types for rc versions:

const mediaTypes = new OpenAPIMediaTypes(

@char0n
Copy link
Member Author

char0n commented Aug 16, 2024

Addressed in #4320

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants