-
-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Adding more informations on My Shares page (table and modal) #174
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work, thank you!
A few things that I have noticed:
- Is the copy link button in the table still necessary? Because you can copy the link in the model. If you want to remove it, I would change the color of the info icon to the primary color (purple)
- Don't you think we could completely remove the author property in the model? Because its value is hard coded
- If the description is too long, the table doesn't look nice in my opinion, maybe you could limit the description length in the table but show the whole description in the modal:
Btw. I really like the idea of the progress bar for the share size :)
I'll see that asap, thank you for the review |
Co-authored-by: Elias Schneider <[email protected]>
Co-authored-by: Elias Schneider <[email protected]>
Co-authored-by: Elias Schneider <[email protected]>
Co-authored-by: Elias Schneider <[email protected]>
Co-authored-by: Elias Schneider <[email protected]>
Yes for sure, but I think the copy link button remains important to make the copy faster, and not disturb people that copied the link like that, I don't really know, but it's not that disturbing
Yes, I can remove it, indeed the user is in My Shares, so he knows that it's his share.
I'll work on this, I can limit the height, but when I try working on the width, I can only use px, I've already had this issue using tables before, but I don't know how to solve it, I put a 300px max-width, so it's good on PC but on smartphones, it's terrible.
Yes I found that it would fill a bit the interface and the result is good. |
I've found a way to bypass this error : display: table;
table-layout: fixed; But the problem is, by setting the layout to fixed, the table cannot slide as before. |
Yeah good point. |
Yes I think this would be the best solution as the description can be seen anyways if you open the modal on mobile. |
Do you know how we can do this directly in React ? |
@pierrbt Mantine does support media queries https://mantine.dev/core/media-query/ Something like this: <MediaQuery largerThan="lg">
{/* the description in here */}
</MediaQuery> |
@stonith404 |
@pierrbt LGTM, thanks again! |
@stonith404 |
The description of the share is now displayed out on the table of My Shares page and by clicking the new button Information, a Modal pops out, on which you can see multiples informations about the share, as shown below.
This Pull Request is related to the Issue #164 . Do not hesitate if you have any other ideas to add on the page, or if you want to modify these changes.
Images :