-
-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🚀 Feature: Add size and description in "My shares" list. #164
Comments
Hello @zikapanam, I'm starting working on this |
@stonith404, I've already talked about it in the discussions, but the share object only contains limited information, can you explain me why ? : {
"id": "M3Njk1N",
"expiration": "2023-07-01T14:16:18.935Z",
"description": "Hello les petits potes",
"views": 0,
"createdAt": "2023-06-23T14:56:29.167Z",
"recipients": []
} |
This is what this new feature looks like. Tell me what you think about it (@zikapanam @stonith404) : If you are ok with this design I'll make a PR. |
@zikapanam, the feature will be merged soon, following the #174 pr. But we'll have to wait the next release to have it on stable platforms |
Merged in #174, the issue can be closed |
I'll close this as soon as it is released. I think next week I should have time to release this. |
This can be closed |
🔖 Feature description
I would like pingvin-share to display size and description as well of the share in "My shares" list.
🎤 Pitch
I think it could be useful to handle user space quota when it will be implemented. Also, the description is useful to know if a share can be safely removed or has be still shared.
The text was updated successfully, but these errors were encountered: