Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update test results summary after BLS 0.10.1 update #810

Merged
merged 1 commit into from
Mar 13, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 2 additions & 10 deletions AllTests-mainnet.md
Original file line number Diff line number Diff line change
Expand Up @@ -51,13 +51,6 @@ OK: 2/2 Fail: 0/2 Skip: 0/2
+ Attestation topics OK
```
OK: 1/1 Fail: 0/1 Skip: 0/1
## Interop
```diff
+ Interop genesis OK
+ Interop signatures OK
+ Mocked start private key OK
```
OK: 3/3 Fail: 0/3 Skip: 0/3
## Official - 0.10.1 - constants & config [Preset: mainnet]
```diff
+ BASE_REWARD_FACTOR 64 [Preset: mainnet] OK
Expand Down Expand Up @@ -172,11 +165,10 @@ OK: 9/9 Fail: 0/9 Skip: 0/9
OK: 1/1 Fail: 0/1 Skip: 0/1
## [Unit - Spec - Block processing] Attestations [Preset: mainnet]
```diff
+ Empty aggregation bit OK
+ Valid attestation OK
+ Valid attestation from previous epoch OK
```
OK: 3/3 Fail: 0/3 Skip: 0/3
OK: 2/2 Fail: 0/2 Skip: 0/2
## [Unit - Spec - Block processing] Deposits [Preset: mainnet]
```diff
+ Deposit at MAX_EFFECTIVE_BALANCE balance (32 ETH) OK
Expand All @@ -199,4 +191,4 @@ OK: 4/4 Fail: 0/4 Skip: 0/4
OK: 8/8 Fail: 0/8 Skip: 0/8

---TOTAL---
OK: 116/117 Fail: 1/117 Skip: 0/117
OK: 112/113 Fail: 1/113 Skip: 0/113
12 changes: 2 additions & 10 deletions AllTests-minimal.md
Original file line number Diff line number Diff line change
Expand Up @@ -78,13 +78,6 @@ OK: 2/2 Fail: 0/2 Skip: 0/2
+ Attestation topics OK
```
OK: 1/1 Fail: 0/1 Skip: 0/1
## Interop
```diff
+ Interop genesis OK
+ Interop signatures OK
+ Mocked start private key OK
```
OK: 3/3 Fail: 0/3 Skip: 0/3
## Official - 0.10.1 - constants & config [Preset: minimal]
```diff
+ BASE_REWARD_FACTOR 64 [Preset: minimal] OK
Expand Down Expand Up @@ -205,11 +198,10 @@ OK: 9/9 Fail: 0/9 Skip: 0/9
OK: 1/1 Fail: 0/1 Skip: 0/1
## [Unit - Spec - Block processing] Attestations [Preset: minimal]
```diff
+ Empty aggregation bit OK
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this one should appear in SKIPPED

+ Valid attestation OK
+ Valid attestation from previous epoch OK
```
OK: 3/3 Fail: 0/3 Skip: 0/3
OK: 2/2 Fail: 0/2 Skip: 0/2
## [Unit - Spec - Block processing] Deposits [Preset: minimal]
```diff
+ Deposit at MAX_EFFECTIVE_BALANCE balance (32 ETH) OK
Expand All @@ -232,4 +224,4 @@ OK: 4/4 Fail: 0/4 Skip: 0/4
OK: 8/8 Fail: 0/8 Skip: 0/8

---TOTAL---
OK: 137/138 Fail: 1/138 Skip: 0/138
OK: 133/134 Fail: 1/134 Skip: 0/134
9 changes: 3 additions & 6 deletions FixtureAll-mainnet.md
Original file line number Diff line number Diff line change
Expand Up @@ -68,11 +68,9 @@ OK: 20/20 Fail: 0/20 Skip: 0/20
```diff
+ [Invalid] att1_bad_extra_index OK
+ [Invalid] att1_bad_replaced_index OK
+ [Invalid] att1_duplicate_index_double_signed OK
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and this

+ [Invalid] att1_duplicate_index_normal_signed OK
+ [Invalid] att2_bad_extra_index OK
+ [Invalid] att2_bad_replaced_index OK
+ [Invalid] att2_duplicate_index_double_signed OK
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and this

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As with the others, this is just rendering consistent/reaching a fixpoint on the interaction between #794 and #780

+ [Invalid] att2_duplicate_index_normal_signed OK
+ [Invalid] invalid_sig_1 OK
+ [Invalid] invalid_sig_1_and_2 OK
Expand All @@ -85,7 +83,7 @@ OK: 20/20 Fail: 0/20 Skip: 0/20
+ [Valid] success_double OK
+ [Valid] success_surround OK
```
OK: 18/18 Fail: 0/18 Skip: 0/18
OK: 16/16 Fail: 0/16 Skip: 0/16
## Official - Operations - Block header [Preset: mainnet]
```diff
+ [Invalid] invalid_parent_root OK
Expand Down Expand Up @@ -129,7 +127,6 @@ OK: 2/2 Fail: 0/2 Skip: 0/2
OK: 9/9 Fail: 0/9 Skip: 0/9
## Official - Sanity - Blocks [Preset: mainnet]
```diff
+ [Invalid] expected_deposit_in_block OK
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and this

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay, well, that might be true, regarding all these "OK" statuses that should be "Skipped", but I just wanted to get devel internally consistent

+ [Invalid] invalid_block_sig OK
+ [Invalid] invalid_state_root OK
+ [Invalid] prev_slot_block_transition OK
Expand All @@ -148,7 +145,7 @@ OK: 9/9 Fail: 0/9 Skip: 0/9
+ [Valid] skipped_slots OK
+ [Valid] voluntary_exit OK
```
OK: 18/18 Fail: 0/18 Skip: 0/18
OK: 17/17 Fail: 0/17 Skip: 0/17
## Official - Sanity - Slots [Preset: mainnet]
```diff
+ Slots - double_empty_epoch OK
Expand All @@ -160,4 +157,4 @@ OK: 18/18 Fail: 0/18 Skip: 0/18
OK: 5/5 Fail: 0/5 Skip: 0/5

---TOTAL---
OK: 110/110 Fail: 0/110 Skip: 0/110
OK: 107/107 Fail: 0/107 Skip: 0/107
9 changes: 3 additions & 6 deletions FixtureAll-minimal.md
Original file line number Diff line number Diff line change
Expand Up @@ -68,11 +68,9 @@ OK: 20/20 Fail: 0/20 Skip: 0/20
```diff
+ [Invalid] att1_bad_extra_index OK
+ [Invalid] att1_bad_replaced_index OK
+ [Invalid] att1_duplicate_index_double_signed OK
+ [Invalid] att1_duplicate_index_normal_signed OK
+ [Invalid] att2_bad_extra_index OK
+ [Invalid] att2_bad_replaced_index OK
+ [Invalid] att2_duplicate_index_double_signed OK
+ [Invalid] att2_duplicate_index_normal_signed OK
+ [Invalid] invalid_sig_1 OK
+ [Invalid] invalid_sig_1_and_2 OK
Expand All @@ -85,7 +83,7 @@ OK: 20/20 Fail: 0/20 Skip: 0/20
+ [Valid] success_double OK
+ [Valid] success_surround OK
```
OK: 18/18 Fail: 0/18 Skip: 0/18
OK: 16/16 Fail: 0/16 Skip: 0/16
## Official - Operations - Block header [Preset: minimal]
```diff
+ [Invalid] invalid_parent_root OK
Expand Down Expand Up @@ -129,7 +127,6 @@ OK: 2/2 Fail: 0/2 Skip: 0/2
OK: 9/9 Fail: 0/9 Skip: 0/9
## Official - Sanity - Blocks [Preset: minimal]
```diff
+ [Invalid] expected_deposit_in_block OK
+ [Invalid] invalid_block_sig OK
+ [Invalid] invalid_state_root OK
+ [Invalid] prev_slot_block_transition OK
Expand All @@ -151,7 +148,7 @@ OK: 9/9 Fail: 0/9 Skip: 0/9
+ [Valid] skipped_slots OK
+ [Valid] voluntary_exit OK
```
OK: 21/21 Fail: 0/21 Skip: 0/21
OK: 20/20 Fail: 0/20 Skip: 0/20
## Official - Sanity - Slots [Preset: minimal]
```diff
+ Slots - double_empty_epoch OK
Expand All @@ -163,4 +160,4 @@ OK: 21/21 Fail: 0/21 Skip: 0/21
OK: 5/5 Fail: 0/5 Skip: 0/5

---TOTAL---
OK: 113/113 Fail: 0/113 Skip: 0/113
OK: 110/110 Fail: 0/110 Skip: 0/110