update test results summary after BLS 0.10.1 update #810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mratsim
reviewed
Mar 14, 2020
| @@ -205,11 +198,10 @@ OK: 9/9 Fail: 0/9 Skip: 0/9 | |||
| OK: 1/1 Fail: 0/1 Skip: 0/1 | |||
| ## [Unit - Spec - Block processing] Attestations [Preset: minimal] | |||
| ```diff | |||
| + Empty aggregation bit OK | |||
There was a problem hiding this comment.
I think this one should appear in SKIPPED
| @@ -68,11 +68,9 @@ OK: 20/20 Fail: 0/20 Skip: 0/20 | |||
| ```diff | |||
| + [Invalid] att1_bad_extra_index OK | |||
| + [Invalid] att1_bad_replaced_index OK | |||
| + [Invalid] att1_duplicate_index_double_signed OK | |||
| + [Invalid] att1_duplicate_index_normal_signed OK | ||
| + [Invalid] att2_bad_extra_index OK | ||
| + [Invalid] att2_bad_replaced_index OK | ||
| + [Invalid] att2_duplicate_index_double_signed OK |
| @@ -129,7 +127,6 @@ OK: 2/2 Fail: 0/2 Skip: 0/2 | |||
| OK: 9/9 Fail: 0/9 Skip: 0/9 | |||
| ## Official - Sanity - Blocks [Preset: mainnet] | |||
| ```diff | |||
| + [Invalid] expected_deposit_in_block OK | |||
There was a problem hiding this comment.
okay, well, that might be true, regarding all these "OK" statuses that should be "Skipped", but I just wanted to get devel internally consistent
|
shouldn't CI check that the MD is accurate, so that if someone forgets to update it, it fails? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intentionally isolating this in its own PR.
The removed tests are legitimately removed/skipped for now, but random PRs ideally shouldn't have to be updating this -- so, this way, make the awareness/consciousness clear.