-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement get_signer_utxo
for in memory storage
#567
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice. Gave it a quick look over just now and will have a proper review tomorrow. Here is what I have so far.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tossed in a few comments/suggestions. I didn't look too hard at the tests as I think there will be a bit of refactoring there after this comment. Good work so far!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
I think the logic looks sound. But can we add another test for the case where we have a fork with chains of the same length and UTXOs on both? You can either modify an existing test or add a new one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good ✅
Description
Initial work for #538.
I'll add the postgres impl (and more tests, if needed) in a different PR to keep this small, if there are no objections :)
Changes
get_signer_utxo
to storage trait (as the issue suggest to use the database)get_signer_utxo
for in memory dbTesting Information
Since we no longer mock it,
should_be_able_to_coordinate_signing_rounds
now also need sbtc txns to work.Checklist: