Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implement get_signer_utxo for pg #584

Merged
merged 16 commits into from
Oct 1, 2024
Merged

feat: implement get_signer_utxo for pg #584

merged 16 commits into from
Oct 1, 2024

Conversation

matteojug
Copy link
Collaborator

Description

Closes #538.

Changes

Testing Information

Add integration test calls to the tests created in #567

Checklist:

  • I have performed a self-review of my code
  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

matteojug
matteojug commented Sep 30, 2024
View reviewed changes
signer/src/storage/postgres.rs Outdated Show resolved Hide resolved
signer/tests/integration/postgres.rs Outdated Show resolved Hide resolved
@matteojug matteojug linked an issue Sep 30, 2024 that may be closed by this pull request
[Feature]: Get signers' UTXO #538
Closed
1 task
@matteojug matteojug changed the title feat: implement get_signer_utxo for pg feat: implement get_signer_utxo for pg Sep 30, 2024
djordon
djordon reviewed Sep 30, 2024
View reviewed changes
Copy link
Contributor

@djordon djordon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gave it a quick look over, looks okay so far. Will take a deeper dive soon enough.

signer/src/storage/mod.rs Outdated Show resolved Hide resolved
signer/src/storage/postgres.rs Outdated Show resolved Hide resolved
signer/src/storage/postgres.rs Outdated Show resolved Hide resolved
signer/src/storage/postgres.rs Outdated Show resolved Hide resolved
Base automatically changed from feat/get-signer-utxo to main October 1, 2024 13:42
djordon
djordon approved these changes Oct 1, 2024
View reviewed changes
Copy link
Contributor

@djordon djordon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

I'm adding a new table for #585. I just realized that this new table can be done in such a way as to make the get_signer_utxo function here much simpler.

signer/src/storage/in_memory.rs Show resolved Hide resolved
signer/src/storage/postgres.rs Outdated Show resolved Hide resolved
@matteojug matteojug merged commit 0d6e5d6 into main Oct 1, 2024
4 checks passed
@matteojug matteojug deleted the feat/get-signer-utxo-pg branch October 1, 2024 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djordon djordon djordon approved these changes

@cylewitruk cylewitruk Awaiting requested review from cylewitruk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature]: Get signers' UTXO
3 participants
@matteojug @djordon @cylewitruk