Add japicmp to test, rx2, rx, extras, and core #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gradle -p mobius-test japicmp ;\ gradle -p mobius-rx2 japicmp ;\ gradle -p mobius-rx japicmp ;\ gradle -p mobius-extras japicmp ;\ gradle -p mobius-core japicmp
Codecov Report
@@ Coverage Diff @@
## master #44 +/- ##
=========================================
Coverage 74.23% 74.23%
Complexity 223 223
=========================================
Files 63 63
Lines 1308 1308
Branches 67 67
=========================================
Hits 971 971
Misses 323 323
Partials 14 14Continue to review full report at Codecov.
|
togi
requested changes
Sep 22, 2018
| @@ -0,0 +1,42 @@ | |||
| // code from: https://github.com/Visistema/Groovy1/blob/ba5eb9b2f19ca0cc8927359ce414c4e1974b7016/gradle/binarycompatibility.gradle#L48 | |||
There was a problem hiding this comment.
Please make sure to update the NOTICE file in the root of the repository too.
| @@ -74,6 +74,7 @@ subprojects { | |||
| variant.javaCompiler.dependsOn(rootProject.tasks.format) | |||
| } | |||
| } else if (proj.plugins.findPlugin('java-library')) { | |||
| proj.apply from: rootProject.file('gradle/binary_compatibility.gradle') | |||
There was a problem hiding this comment.
I'm not sure how to use japicmp-gradle-plugin on an aar file.
Updated |
togi
approved these changes
Sep 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add japicmp to test, rx2, rx, extras, and core
Adding japicmp via gradle was mentioned on #40 (comment). I took the implementation from Visistema/Groovy1.