Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve remaining API incompatabilities #1

Closed
DrewCarlson opened this issue Sep 22, 2018 · 2 comments
Closed

Resolve remaining API incompatabilities #1

DrewCarlson opened this issue Sep 22, 2018 · 2 comments

Comments

@DrewCarlson
Copy link
Owner

DrewCarlson commented Sep 22, 2018 •
edited
Loading

https://37-147952971-gh.circle-artifacts.com/0/home/circleci/kotlin-mobius/jvm/core-jvm/build/reports/japi.html

Most of the issues are CLASS_NOW_FINAL and METHOD_NOW_FINAL. I'm not convinced anything needs to be open but it can be done if necessary.

First no-arg constructor removed to enforce non-null model.

MergedEventSource.from and MobiusLoop$Builder.eventSources signature simplified, not a breaking change.

Mobius.loop needs to return MobiusLoop$Builder. Resolved

Throwables.propagate needs @mpp.JvmStatic, not really an issue but doesn't hurt to have. Resolved
@DrewCarlson DrewCarlson mentioned this issue Sep 22, 2018
Open
@bootstraponline
Copy link

you may be interested in spotify/mobius#44

@DrewCarlson
Copy link
Owner Author

I'm satisfied with compatibility, classes can be opened individually should it be necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bootstraponline @DrewCarlson