Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Particle platform compatibility #48

Merged
merged 2 commits into from
Jan 15, 2024
Merged

Particle platform compatibility #48

merged 2 commits into from
Jan 15, 2024

Commits on Jan 13, 2024

  1. Update sfe_bus.cpp for Particle Platform 

    I haven't done much platform porting so I'm not exactly sure the most correct way to fix this, but casting data uint8_t* to char* resolves the compiler error:
 invalid conversion from 'uint8_t*' {aka 'unsigned char*'} to 'char*' 

I would guess the right next step is to dig into DeviceOS serial handling but maybe someone can comment.

If this is an acceptable solution, or if it's safe to cast to char * for all platforms I'd like to see it merge into main so I don't have to remember it in the future.
    @niabassey
    niabassey authored Jan 13, 2024
    Configuration menu
    Copy the full SHA
    380277a View commit details
    Browse the repository at this point in the history

  2. N/C, whitespace only 

    Adjusted whitespace
    @niabassey
    niabassey authored Jan 13, 2024
    Configuration menu
    Copy the full SHA
    945b283 View commit details
    Browse the repository at this point in the history