Particle platform compatibility #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I haven't done much platform porting so I'm not exactly sure the most correct way to fix this, but casting data uint8_t* to char* resolves the compiler error:
invalid conversion from 'uint8_t*' {aka 'unsigned char*'} to 'char*'
I would guess the right next step is to dig into DeviceOS serial handling but maybe someone can comment.
If this is an acceptable solution, or if it's safe to cast to char * for all platforms I'd like to see it merge into main so I don't have to remember it in the future.
Adjusted whitespace
|
Hi Nia (@niabassey ), Sure, we can merge this... Best wishes, |
Thanks Paul! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I haven't done much platform porting so I'm not exactly sure the most correct way to fix this, but casting
datauint8_t* to char* resolves the Particle Workbench compiler error:invalid conversion from 'uint8_t*' {aka 'unsigned char*'} to 'char*'I would guess a next step would be to dig into DeviceOS serial handling but maybe someone can comment and save me the blind effort.
If this is an acceptable solution, or if it's safe to cast to char * for all platforms I'd like to see it merge into main so the library will drop into Particle Workbench without having to track changes. Comments?