Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance capabilities to simulate PSFs with larger JWST pupil #908

Merged
merged 4 commits into from
Sep 12, 2024
Merged

Enhance capabilities to simulate PSFs with larger JWST pupil #908

merged 4 commits into from
Sep 12, 2024

Conversation

obi-wan76
Copy link
Collaborator

@obi-wan76 obi-wan76 commented Sep 3, 2024 •
edited
Loading

This PR is for enhance capabilities to simulate PSFs with larger JWST pupils. The changes are only in the load_wss functions in order to match the observed OPD to the larger pupil sizes. This PR also adds documentation for this enhance support.

@pep8speaks
Copy link

pep8speaks commented Sep 3, 2024 •
edited
Loading

Hello @obi-wan76, Thank you for updating !

Line 1649:19: E126 continuation line over-indented for hanging indent

Comment last updated at 2024-09-12 11:53:31 UTC

@obi-wan76 obi-wan76 added this to the Release 1.3.1 milestone Sep 3, 2024
obi-wan76
obi-wan76 commented Sep 11, 2024
View reviewed changes
Copy link
Collaborator Author

@obi-wan76 obi-wan76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for reviewing and making the changes.

docs/jwst_large_psf.ipynb Outdated Show resolved Hide resolved
@mperrin mperrin mentioned this pull request Sep 11, 2024
Merged
@obi-wan76
Copy link
Collaborator Author

@mperrin thanks for making the changes, it looks good. I cannot approve it because I am the author but you can go ahead and approve it.
btw, you are right about the OPD path, I changed the file locally but did not add it to this PR, thanks for fixing my mistake!

mperrin
mperrin approved these changes Sep 12, 2024
View reviewed changes
Copy link
Collaborator

@mperrin mperrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, minor fixes applied as needed, all good now.

@mperrin mperrin merged commit 9cf185a into develop Sep 12, 2024
15 checks passed
@mperrin mperrin deleted the webbpsf_load_wss_pupil_size branch September 12, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mperrin mperrin mperrin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Release 1.4
Development

Successfully merging this pull request may close these issues.
3 participants
@obi-wan76 @pep8speaks @mperrin