add CI tests for mast_wss, in test_mast_wss.py #911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @mperrin, Thank you for updating !
Comment last updated at 2024-09-11 20:57:38 UTC |
mperrin
force-pushed
the
add_test_mast_wss
branch
from
a4a1db1
to
5380820
Compare
obi-wan76
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the course of testing #908 I wanted to add a unit test to test that new code in the CI. And I realized I had long ago wrote -- but never committed, by accident -- a
test_mast_wss.pyfile.This PR adds that file, including with an added test for the OPD rescaling feature added in #908. As such, we should expect the CI tests for this PR to fail until #908 is merged, and then subsequently pass after that.