Merge pull request #134 from nix6839/fix-#133

Don't crash when encounter unknown node like `as`
solidjs-community · Apr 13, 2024 · 6a89e2c · 6a89e2c
2 parents b65cf30 + a3f07a2
commit 6a89e2c
Show file tree

Hide file tree

Showing 3 changed files with 23 additions and 3 deletions.
diff --git a/docs/reactivity.md b/docs/reactivity.md
@@ -645,6 +645,10 @@ function createFoo(v) {}
 const [bar, setBar] = createSignal();
 createFoo([bar]);
 
+function createFoo(v) {}
+const [bar, setBar] = createSignal();
+createFoo({ onBar: () => bar() } as object);
+
 const [bar, setBar] = createSignal();
 X.createFoo(() => bar());
 
@@ -812,6 +816,10 @@ const m = createMemo(() => 5)! as Accessor<number>;
 
 const m = createMemo(() => 5) satisfies Accessor<number>;
 
+const [s] = createSignal("a" as string);
+
+createFoo("a" as string);
+
 function Component(props) {
   return (
     <div>

diff --git a/src/rules/reactivity.ts b/src/rules/reactivity.ts
@@ -843,6 +843,7 @@ export default createRule<Options, MessageIds>({
               this.skip(); // poor-man's `findInScope`: don't enter child scopes
             }
           },
+          fallback: "iteration", // Don't crash when encounter unknown node.
         });
       };
 

diff --git a/test/rules/reactivity.test.ts b/test/rules/reactivity.test.ts
@@ -158,9 +158,12 @@ export const cases = run("reactivity", rule, {
     `function createFoo(v) {}
     const [bar, setBar] = createSignal();
     createFoo([bar]);`,
-    // `function createFoo(v) {}
-    // const [bar, setBar] = createSignal();
-    // createFoo((() => () => bar())());`,
+    {
+      code: `function createFoo(v) {}
+      const [bar, setBar] = createSignal();
+      createFoo({ onBar: () => bar() } as object);`,
+      ...tsOnlyTest,
+    },
     `const [bar, setBar] = createSignal();
     X.createFoo(() => bar());`,
     `const [bar, setBar] = createSignal();
@@ -308,6 +311,14 @@ export const cases = run("reactivity", rule, {
       code: `const m = createMemo(() => 5) satisfies Accessor<number>;`,
       ...tsOnlyTest,
     },
+    {
+      code: `const [s] = createSignal('a' as string)`,
+      ...tsOnlyTest,
+    },
+    {
+      code: `createFoo('a' as string)`,
+      ...tsOnlyTest,
+    },
     // functions in JSXExpressionContainers
     `function Component(props) {
       return (