Make new fixture a unit test, add a few more.

solidjs-community · Apr 13, 2024 · a3f07a2 · a3f07a2
1 parent 52e650b
commit a3f07a2
Show file tree

Hide file tree

Showing 3 changed files with 22 additions and 14 deletions.
diff --git a/docs/reactivity.md b/docs/reactivity.md
@@ -645,6 +645,10 @@ function createFoo(v) {}
 const [bar, setBar] = createSignal();
 createFoo([bar]);
 
+function createFoo(v) {}
+const [bar, setBar] = createSignal();
+createFoo({ onBar: () => bar() } as object);
+
 const [bar, setBar] = createSignal();
 X.createFoo(() => bar());
 
@@ -812,6 +816,10 @@ const m = createMemo(() => 5)! as Accessor<number>;
 
 const m = createMemo(() => 5) satisfies Accessor<number>;
 
+const [s] = createSignal("a" as string);
+
+createFoo("a" as string);
+
 function Component(props) {
   return (
     <div>

diff --git a/test/fixture/valid/as-expression/main.tsx b/test/fixture/valid/as-expression/main.tsx
diff --git a/test/rules/reactivity.test.ts b/test/rules/reactivity.test.ts
@@ -158,9 +158,12 @@ export const cases = run("reactivity", rule, {
     `function createFoo(v) {}
     const [bar, setBar] = createSignal();
     createFoo([bar]);`,
-    // `function createFoo(v) {}
-    // const [bar, setBar] = createSignal();
-    // createFoo((() => () => bar())());`,
+    {
+      code: `function createFoo(v) {}
+      const [bar, setBar] = createSignal();
+      createFoo({ onBar: () => bar() } as object);`,
+      ...tsOnlyTest,
+    },
     `const [bar, setBar] = createSignal();
     X.createFoo(() => bar());`,
     `const [bar, setBar] = createSignal();
@@ -308,6 +311,14 @@ export const cases = run("reactivity", rule, {
       code: `const m = createMemo(() => 5) satisfies Accessor<number>;`,
       ...tsOnlyTest,
     },
+    {
+      code: `const [s] = createSignal('a' as string)`,
+      ...tsOnlyTest,
+    },
+    {
+      code: `createFoo('a' as string)`,
+      ...tsOnlyTest,
+    },
     // functions in JSXExpressionContainers
     `function Component(props) {
       return (