TDL-22608 update backoff conditions

CHANGELOG.md

@@ -1,5 +1,7 @@
 # Changelog
 
+## 1.0.1
+  * Updated Backoff Conditions added support for ConnectionResetError(104) and RemoteDisconnected Error.[#19](https://github.com/singer-io/tap-sailthru/pull/19)
 
 ## 1.0.0
   * Removed Additiona Package Dependencies [#16](https://github.com/singer-io/tap-sailthru/pull/16)

setup.py

@@ -10,7 +10,7 @@
 
 setup(
     name="tap-sailthru",
-    version="1.0.0",
+    version="1.0.1",
     description="Singer.io tap for the SailThru API",
     long_description=readme,
     long_description_content_type='text/markdown',

tap_sailthru/client.py

@@ -7,7 +7,7 @@
 import math
 import sys
 from typing import Union
-
+from http.client import RemoteDisconnected
 import backoff
 from requests import Session
 from requests.exceptions import Timeout
@@ -320,10 +320,13 @@ def _build_request(self, endpoint, params, method):
                           SailthruClient429Error,
                           max_tries=MAX_RETRIES)
     @backoff.on_exception(backoff.expo,
-                          (SailthruClientError,
+                          (Timeout,
+                          ConnectionError,
+                          RemoteDisconnected,
+                          SailthruClientError,
+                          ConnectionResetError,
                           SailthruServer5xxError,
-                          SailthruClientStatsNotReadyError,
-                          Timeout),
+                          SailthruClientStatsNotReadyError),
                           max_tries=MAX_RETRIES,
                           factor=2)
     def _make_request(self, url, payload, method):

tests/unittests/test_error_handling.py

@@ -1,7 +1,8 @@
-from unittest import mock
-import tap_sailthru.client as client
 import unittest
 import requests
+from unittest import mock
+from http.client import RemoteDisconnected
+import tap_sailthru.client as client
 
 # mocked response class
 class Mockresponse:
@@ -338,3 +339,37 @@ def test_200_response(self, mocked_sleep, mocked_request):
 
         # verify the mocked data is coming as expected
         self.assertEqual(response, response_json)
+
+    def test_connection_error_backoff(self, mocked_sleep, mocked_request):
+        """
+            Test case to verify error is not raise for 200 status code
+        """
+
+        mocked_request.side_effect = ConnectionResetError()
+
+        # create sailthru client
+        sailthru_client = client.SailthruClient("test_api_key", "test_api_secret", "test_user_agent")
+        # function call
+        try:
+            response = sailthru_client._build_request("test_endpoint", {}, "GET")
+        except ConnectionResetError:
+            pass
+
+        self.assertEqual(mocked_request.call_count, 3)
+
+    def test_remotedisconnected_error_backoff(self, mocked_sleep, mocked_request):
+        """
+            Test case to verify error is not raise for 200 status code
+        """
+
+        mocked_request.side_effect = RemoteDisconnected()
+
+        # create sailthru client
+        sailthru_client = client.SailthruClient("test_api_key", "test_api_secret", "test_user_agent")
+        # function call
+        try:
+            response = sailthru_client._build_request("test_endpoint", {}, "GET")
+        except RemoteDisconnected:
+            pass
+
+        self.assertEqual(mocked_request.call_count, 3)