TDL-22608 update backoff conditions #19
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgandhi1311
reviewed
Apr 3, 2023
CHANGELOG.md
Outdated
| @@ -1,5 +1,7 @@ | |||
| # Changelog | |||
|
|
|||
| ## 1.0.1 | |||
| * Updated Backoff Conditions added support for ConnectionResetError(104) and RemoteDisconnected Error. | |||
shantanu73
approved these changes
Apr 3, 2023
dsprayberry
requested changes
Apr 3, 2023
Comment on lines
1
to
5
| from unittest import mock | ||
| import tap_sailthru.client as client | ||
| from http.client import RemoteDisconnected | ||
| import unittest | ||
| import requests |
There was a problem hiding this comment.
Is pylint okay with this order of imports? The grouping feels strange, eg line 1 and line 4?
CHANGELOG.md
Outdated
| @@ -1,5 +1,7 @@ | |||
| # Changelog | |||
|
|
|||
| ## 1.0.1 | |||
| * Updated Backoff Conditions added support for ConnectionResetError(104) and RemoteDisconnected Error. | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Manual QA steps
Risks
Rollback steps