Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup root build.gradle.kts. Remove duplicate dependency #13391

Conversation

maksym-moroz
Copy link
Contributor

First time contributor checklist

Contributor checklist

  • Samsung Note 10+, Android 12
  • My contribution is fully baked and ready to be merged as is
  • I ensure that all the open issues my contribution fixes are mentioned in the commit message of my first commit using the Fixes #1234 syntax

Description

  • Register tasks instead of creating them eagerly to improve configuration times
  • Use onlyIf predicate block to run qa task conditionally
  • Remove duplicate dependency on kotlinx.collections.immutable

@greyson-signal
Copy link
Contributor

Mostly good! We can't use onlyIf -- seems like the project fails to configure. I'm no gradle expert, but the documentation suggests that it's likely because onlyIf prevents execution of the task, but the error itself is happening during configuration because it can't find the lint task on the benchmark project. So we need to prevent the task being registered at all if those conditions aren't met.

So I reverted that little bit, but the rest will be in the 6.46 release. Thank you!

@maksym-moroz
Copy link
Contributor Author

Makes sense. I will look into onlyIf in more detail later. Thanks for swift response!

TwoLeaves pushed a commit to TwoLeaves/Signal-antisocial that referenced this pull request Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants