Skip to content

Commit

Permalink
Register gradle tasks instead of creating eagerly.
Browse files Browse the repository at this point in the history
Signed-off-by: Maksym Moroz <[email protected]>

Resolves signalapp#13391
  • Loading branch information
maksym-moroz authored and TwoLeaves committed Feb 7, 2024
1 parent 7179b4c commit 50e314d
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 7 deletions.
12 changes: 6 additions & 6 deletions build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ tasks.withType<Wrapper> {
apply(from = "${rootDir}/constants.gradle.kts")

subprojects {
if (JavaVersion.current().isJava8Compatible()) {
if (JavaVersion.current().isJava8Compatible) {
allprojects {
tasks.withType<Javadoc> {
(options as StandardJavadocDocletOptions).addStringOption("Xdoclint:none", "-quiet")
Expand All @@ -50,16 +50,16 @@ subprojects {

val skipQa = setOf("Signal-Android", "libsignal-service", "lintchecks", "benchmark", "core-util-jvm", "logging")

if (!skipQa.contains(project.name) && !project.name.endsWith("-app")) {
task("qa") {
if (project.name !in skipQa && !project.name.endsWith("-app")) {
tasks.register("qa") {
group = "Verification"
description = "Quality Assurance. Run before pushing"
dependsOn("clean", "testReleaseUnitTest", "lintRelease")
}
}
}

task("buildQa") {
tasks.register("buildQa") {
group = "Verification"
description = "Quality Assurance for build logic."
dependsOn(
Expand All @@ -69,7 +69,7 @@ task("buildQa") {
)
}

task("qa") {
tasks.register("qa") {
group = "Verification"
description = "Quality Assurance. Run before pushing."
dependsOn(
Expand All @@ -92,7 +92,7 @@ tasks.register("clean", Delete::class) {
delete(rootProject.buildDir)
}

task("format") {
tasks.register("format") {
group = "Formatting"
description = "Runs the ktlint formatter on all sources in this project and included builds"
dependsOn(
Expand Down
1 change: 0 additions & 1 deletion dependencies.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,6 @@ dependencyResolutionManagement {

// Can"t use the newest version because it hits some weird NoClassDefFoundException
library("jknack-handlebars", "com.github.jknack:handlebars:4.0.7")
library("kotlinx-collections-immutable", "org.jetbrains.kotlinx:kotlinx-collections-immutable:0.3.5")

// Mp4Parser
library("mp4parser-isoparser", "org.mp4parser", "isoparser").versionRef("mp4parser")
Expand Down

0 comments on commit 50e314d

Please sign in to comment.