Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Status: Colorize more network icons (16px-22px) #470

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

newhoa
Copy link
Contributor

@newhoa newhoa commented Jul 20, 2024

Use full-color icons for more network icons (matching the previous colorization of the wifi icons). These icons match the rest of the color theme better and are easier to see in both light and dark themes.

Remove grayscale network icons from the panel folder. Symbolic icons (which automatically recolorize) are now common so these grayscale icons should no longer be needed. In places where developers have chosen not to use symbolic icons, we shouldn't force the look. This also solves an issue where the grayscale icons were difficult to see with mixed light and dark themes (especially with per-app light and dark theme preferences becoming more common).

Remove some empty nm- prefixed icons. These may have been used to hide the network type tags (3G, 4G, etc.), but that seems hacky and reduces information that the user might want. network-manager-applet provides these "badges", so removing them should allow the network-manager provided icons to be used.

Fix some files not being the right size (ad-hoc was 20x22px).

Fix issue where wifi icons were colored differently at different sizes.

Fix issue where some wired network icons were different designs at different sizes.

Use full-color icons for more network icons (matching
the previous colorization of the wifi icons). These icons
match the rest of the color theme better and are easier
to see in both light and dark themes.

Remove grayscale network icons from the panel folder.
Symbolic icons (which automatically recolorize) are now
common so these grayscale icons should no longer be needed.
In places where developers have chosen not to use symbolic
icons, we shouldn't force the look. This also solves an issue
where the grayscale icons were difficult to see with mixed
light and dark themes (especially with per-app light and dark
theme preferences becoming more common).

Remove some empty `nm-` prefixed icons. These may have been
used to hide the network type tags (3G, 4G, etc.), but that
seems hacky and reduces information that the user might want.
network-manager-applet provides these "badges", so removing them
should allow the network-manager provided icons to be used.

Fix some files not being the right size (ad-hoc was 20x22px).

Fix issue where wifi icons were colored differently at different sizes.

Fix issue where some wired network icons were different designs at different sizes.
@Skif-off
Copy link

so removing them should allow the network-manager provided icons to be used

They don't seem very beautiful...

@newhoa
Copy link
Contributor Author

newhoa commented Aug 16, 2024

so removing them should allow the network-manager provided icons to be used

They don't seem very beautiful...

Do you mean the colorized icons in this PR or the network-manager project's badges (here)?

If someone wants to work on a set of network-manager badges that would be fine. I personally have no interest in working on them (and I have no way of testing them or seeing what it looks like in action).

@Skif-off
Copy link

Do you mean the colorized icons in this PR or the network-manager project's badges (here)?

Of course, the network-manager project's icons :)

But I'm not sure that colorized icons look better than the old ones. On the other hand, there has been no discussion here (yet?)...

P.S.

and I have no way of testing them or seeing what it looks like in action

Don't you have any network manager?

@newhoa
Copy link
Contributor Author

newhoa commented Aug 24, 2024

Do you mean the colorized icons in this PR or the network-manager project's badges (here)?

Of course, the network-manager project's icons :)

But I'm not sure that colorized icons look better than the old ones. On the other hand, there has been no discussion here (yet?)...

They are more consistent and should be more legible at least (unless someone is using a very specifically blue-colored panel 😛), the designs themselves are unchanged. Probably will start merging all these "colorize panel icon" PRs in the next few days. I guess if anything is wrong people will mention it then or after next release.

P.S.

and I have no way of testing them or seeing what it looks like in action

Don't you have any network manager?

I don't have any cellular-based devices to test the emblems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants