Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Dark" theme: Incorrect network icons in notification windows #477

Open
Skif-off opened this issue Aug 24, 2024 · 3 comments
Open

"Dark" theme: Incorrect network icons in notification windows #477

Skif-off opened this issue Aug 24, 2024 · 3 comments

Comments

@Skif-off
Copy link

0.19/upstream vs. expected:

screen

@newhoa
Copy link
Contributor

newhoa commented Aug 27, 2024

Thanks for reporting!

#470 should fix this issue since it unifies the light and dark network icons into a single set (and removes them from the dark theme altogether).

The "colorize" PRs are meant to unify the light and dark themes, meaning the dark theme should no loner be needed (the dark theme will be deprecated and removed in the future). So issues like these that are specific to the dark theme will hopefully be resolved and easier to address in the future.

@Skif-off
Copy link
Author

the dark theme will be deprecated and removed in the future

Will be removed before the next release?

@newhoa
Copy link
Contributor

newhoa commented Oct 8, 2024

the dark theme will be deprecated and removed in the future

Will be removed before the next release?

We went ahead and did a release before making the "colorize" changes that will remove the Dark icons (will probably start merging those in the next few days).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants