-
-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update to latest ddev (v1.22.7) #145
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|
|
@@ -15,13 +15,13 @@ RUN echo "deb [signed-by=/etc/apt/keyrings/ddev.gpg] https://pkg.ddev.com/apt/ * | |||||||||||
RUN sudo apt update && sudo apt install -y ddev | ||||||||||||
|
||||||||||||
# Install GitUI (terminal-ui for git) | ||||||||||||
RUN wget https://github.com/extrawurst/gitui/releases/download/v0.24.3/gitui-linux-musl.tar.gz -P /tmp | ||||||||||||
RUN wget https://github.com/extrawurst/gitui/releases/download/v0.25.1/gitui-linux-musl.tar.gz -P /tmp | ||||||||||||
RUN sudo tar xzf /tmp/gitui-linux-musl.tar.gz -C /usr/bin | ||||||||||||
|
||||||||||||
# (get latest Minio version from https://dl.min.io/client/mc/release/linux-amd64/) | ||||||||||||
# Install Minio client | ||||||||||||
RUN wget https://dl.min.io/client/mc/release/linux-amd64/mcli_20231220071422.0.0_amd64.deb | ||||||||||||
RUN sudo dpkg -i mcli_20231220071422.0.0_amd64.deb | ||||||||||||
RUN wget https://dl.min.io/client/mc/release/linux-amd64/mcli_20240303001308.0.0_amd64.deb | ||||||||||||
RUN sudo dpkg -i mcli_20240303001308.0.0_amd64.deb | ||||||||||||
Comment on lines
+23
to
+24
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The Minio client installation uses a specific version ( - RUN wget https://dl.min.io/client/mc/release/linux-amd64/mcli_20240303001308.0.0_amd64.deb
+ ARG MINIO_CLIENT_VERSION=20240303001308.0.0
+ RUN wget https://dl.min.io/client/mc/release/linux-amd64/mcli_${MINIO_CLIENT_VERSION}_amd64.deb Committable suggestion
Suggested change
|
||||||||||||
RUN sudo mv /usr/local/bin/mcli /usr/local/bin/mc | ||||||||||||
|
||||||||||||
# End workspace-base | ||||||||||||
Comment on lines
15
to
27
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Using |
||||||||||||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The command to download GitUI uses a hard-coded version (
v0.25.1
). Consider using a variable for the version number to make future updates easier.Committable suggestion