fix: update to latest ddev (v1.22.7) #145
Conversation
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
WalkthroughThe recent updates involve upgrading the PHP and database versions in the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review Status
Actionable comments generated: 3
Configuration used: CodeRabbit UI
Files selected for processing (3)
- .ddev/config.yaml (2 hunks)
- .gitpod.yml (1 hunks)
- .gitpod/images/Dockerfile (1 hunks)
Files skipped from review due to trivial changes (1)
- .gitpod.yml
Additional comments: 3
.ddev/config.yaml (3)
- 4-4: Updating the PHP version to "8.3" is a significant change that may affect compatibility with existing code. Ensure that all dependencies and the project codebase are compatible with PHP 8.3.
- 11-11: The database version update to "10.6" is important for performance and security improvements. Verify that the application's database interactions are compatible with MariaDB 10.6.
- 277-279: The addition of
drush sql:sanitize,drush updatedb, anddrush cache:rebuildcommands in thepost-import-dbhooks is a good practice for maintaining a clean and updated database state. Ensure that these commands do not conflict with any custom database setup or sanitization processes already in place.
| @@ -15,13 +15,13 @@ RUN echo "deb [signed-by=/etc/apt/keyrings/ddev.gpg] https://pkg.ddev.com/apt/ * | |||
| RUN sudo apt update && sudo apt install -y ddev | |||
|
|
|||
| # Install GitUI (terminal-ui for git) | |||
| RUN wget https://github.com/extrawurst/gitui/releases/download/v0.24.3/gitui-linux-musl.tar.gz -P /tmp | |||
| RUN wget https://github.com/extrawurst/gitui/releases/download/v0.25.1/gitui-linux-musl.tar.gz -P /tmp | |||
There was a problem hiding this comment.
The command to download GitUI uses a hard-coded version (v0.25.1). Consider using a variable for the version number to make future updates easier.
- RUN wget https://github.com/extrawurst/gitui/releases/download/v0.25.1/gitui-linux-musl.tar.gz -P /tmp
+ ARG GITUI_VERSION=v0.25.1
+ RUN wget https://github.com/extrawurst/gitui/releases/download/${GITUI_VERSION}/gitui-linux-musl.tar.gz -P /tmpCommittable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| RUN wget https://github.com/extrawurst/gitui/releases/download/v0.25.1/gitui-linux-musl.tar.gz -P /tmp | |
| ARG GITUI_VERSION=v0.25.1 | |
| RUN wget https://github.com/extrawurst/gitui/releases/download/${GITUI_VERSION}/gitui-linux-musl.tar.gz -P /tmp |
| RUN wget https://dl.min.io/client/mc/release/linux-amd64/mcli_20240303001308.0.0_amd64.deb | ||
| RUN sudo dpkg -i mcli_20240303001308.0.0_amd64.deb |
There was a problem hiding this comment.
The Minio client installation uses a specific version (20240303001308.0.0). Similar to GitUI, consider using a variable for the version number to simplify updates.
- RUN wget https://dl.min.io/client/mc/release/linux-amd64/mcli_20240303001308.0.0_amd64.deb
+ ARG MINIO_CLIENT_VERSION=20240303001308.0.0
+ RUN wget https://dl.min.io/client/mc/release/linux-amd64/mcli_${MINIO_CLIENT_VERSION}_amd64.debCommittable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| RUN wget https://dl.min.io/client/mc/release/linux-amd64/mcli_20240303001308.0.0_amd64.deb | |
| RUN sudo dpkg -i mcli_20240303001308.0.0_amd64.deb | |
| ARG MINIO_CLIENT_VERSION=20240303001308.0.0 | |
| RUN wget https://dl.min.io/client/mc/release/linux-amd64/mcli_${MINIO_CLIENT_VERSION}_amd64.deb | |
| RUN sudo dpkg -i mcli_20240303001308.0.0_amd64.deb |
| RUN sudo apt update && sudo apt install -y ddev | ||
|
|
||
| # Install GitUI (terminal-ui for git) | ||
| RUN wget https://github.com/extrawurst/gitui/releases/download/v0.24.3/gitui-linux-musl.tar.gz -P /tmp | ||
| RUN wget https://github.com/extrawurst/gitui/releases/download/v0.25.1/gitui-linux-musl.tar.gz -P /tmp | ||
| RUN sudo tar xzf /tmp/gitui-linux-musl.tar.gz -C /usr/bin | ||
|
|
||
| # (get latest Minio version from https://dl.min.io/client/mc/release/linux-amd64/) | ||
| # Install Minio client | ||
| RUN wget https://dl.min.io/client/mc/release/linux-amd64/mcli_20231220071422.0.0_amd64.deb | ||
| RUN sudo dpkg -i mcli_20231220071422.0.0_amd64.deb | ||
| RUN wget https://dl.min.io/client/mc/release/linux-amd64/mcli_20240303001308.0.0_amd64.deb | ||
| RUN sudo dpkg -i mcli_20240303001308.0.0_amd64.deb | ||
| RUN sudo mv /usr/local/bin/mcli /usr/local/bin/mc | ||
|
|
||
| # End workspace-base |
There was a problem hiding this comment.
📝 NOTE
This review was outside the diff hunks and was mapped to the diff hunk with the greatest overlap. Original lines [4-25]
Using sudo in Dockerfiles is generally discouraged as it can introduce security vulnerabilities and configuration errors. Since the Dockerfile switches to the gitpod user and then back to using sudo, consider optimizing these commands to run as the root user directly where possible, and then switch to the gitpod user only when necessary.
|
This is also resolved by #146 |
|
And of course it's DDEV v1.23.0 now. |
|
fixed by #146 |
I am still getting an error when running
ddev drush si demo_umami -ySummary by CodeRabbit