Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DeliverTx callback #529

Merged
merged 1 commit into from
Jul 25, 2024
Merged

Add DeliverTx callback #529

merged 1 commit into from
Jul 25, 2024

Conversation

codchen
Copy link
Collaborator

@codchen codchen commented Jul 23, 2024

Describe your changes and provide context

Add a field in context to set callbacks that would be run at the end of DeliverTx on the base store, regardless of the outcome of the transaction (e.g. bump nonce)

Testing performed to validate your change

integration test in sei-test

Copy link

codecov bot commented Jul 23, 2024

Codecov Report

Attention: Patch coverage is 11.11111% with 8 lines in your changes missing coverage. Please review.

Project coverage is 55.26%. Comparing base (8653b19) to head (ee91f65).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #529      +/-   ##
==========================================
- Coverage   55.27%   55.26%   -0.01%     
==========================================
  Files         631      631              
  Lines       54318    54327       +9     
==========================================
  Hits        30026    30026              
- Misses      22149    22157       +8     
- Partials     2143     2144       +1     
Files Coverage Δ
baseapp/baseapp.go 65.15% <25.00%> (-0.23%) ⬇️
types/context.go 56.77% <0.00%> (-1.23%) ⬇️

... and 1 file with indirect coverage changes

@codchen codchen merged commit 71dd7f1 into main Jul 25, 2024
14 of 15 checks passed
@codchen codchen deleted the ante-hooks branch July 25, 2024 03:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant