Bump nonce even if tx fails #1778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codchen
force-pushed
the
always-bump-nonce
branch
2 times, most recently
from
697f12e
to
fa96d76
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1778 +/- ##
==========================================
- Coverage 61.64% 60.76% -0.89%
==========================================
Files 365 380 +15
Lines 26178 27975 +1797
==========================================
+ Hits 16138 16998 +860
- Misses 8967 9830 +863
- Partials 1073 1147 +74
|
codchen
force-pushed
the
always-bump-nonce
branch
3 times, most recently
from
7e4862f
to
c1ce24d
Compare
philipsu522
approved these changes
Jul 31, 2024
codchen
force-pushed
the
always-bump-nonce
branch
from
8067baa
to
40270ac
Compare
codchen
force-pushed
the
always-bump-nonce
branch
from
40270ac
to
e9dc4e9
Compare
yzang2019
added a commit
that referenced
this pull request
Aug 15, 2024
* main: Add more DEX dapp tests (#1809) Add basic LST integration tests (#1814) Allow CW->ERC pointers to be called through wasmd precompile (#1785) Bump nonce even if tx fails (#1778) Fix docker setup for local cluster (#1806) Tune Configs (#1813) V5.7.5 release (#1805) Evidence Max Bytes Update (#1812) Add dApp Tests (#1802) [EVM] Tune configs (#1800) Revert dex removal (#1801) Do not charge gas for feecollector address query (#1795)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
Due to the way tendermint mempool works, it is possible for transactions that pass ante handlers during CheckTx to fail during DeliverTx. In such cases, we still want nonce to be incremented for those transactions.
corresponding change in sei-cosmos: sei-protocol/sei-cosmos#529
Testing performed to validate your change
integration test