Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suppress noisy chainID logs #1892

Merged
merged 3 commits into from
Oct 11, 2024
Merged

Suppress noisy chainID logs #1892

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5c2afa8
Suppress noisy chainID logs
yzang2019 Oct 8, 2024
3b7d6ed
Merge branch 'main' into yzang/reduce-noisy-log
philipsu522 Oct 8, 2024
0f562ee
Merge branch 'main' into yzang/reduce-noisy-log
philipsu522 Oct 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions x/evm/ante/sig.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,13 +47,13 @@
case ethtypes.LegacyTxType:
// legacy either can have a zero or correct chain ID
if txChainID.Cmp(big.NewInt(0)) != 0 && txChainID.Cmp(chainID) != 0 {
ctx.Logger().Error("chainID mismatch", "txChainID", ethTx.ChainId(), "chainID", chainID)
ctx.Logger().Debug("chainID mismatch", "txChainID", ethTx.ChainId(), "chainID", chainID)

Check warning on line 50 in x/evm/ante/sig.go

View check run for this annotation

Codecov / codecov/patch

x/evm/ante/sig.go#L50 

Added line #L50 was not covered by tests
return ctx, sdkerrors.ErrInvalidChainID
}
default:
// after legacy, all transactions must have the correct chain ID
if txChainID.Cmp(chainID) != 0 {
ctx.Logger().Error("chainID mismatch", "txChainID", ethTx.ChainId(), "chainID", chainID)
ctx.Logger().Debug("chainID mismatch", "txChainID", ethTx.ChainId(), "chainID", chainID)

Check warning on line 56 in x/evm/ante/sig.go

View check run for this annotation

Codecov / codecov/patch

x/evm/ante/sig.go#L56 

Added line #L56 was not covered by tests
return ctx, sdkerrors.ErrInvalidChainID
}
}
Expand Down
Loading