Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress noisy chainID logs #1892

Merged
merged 3 commits into from
Oct 11, 2024
Merged

Suppress noisy chainID logs #1892

merged 3 commits into from
Oct 11, 2024

Conversation

yzang2019
Copy link
Contributor

@yzang2019 yzang2019 commented Oct 8, 2024

Describe your changes and provide context

This PR suppress the noisy error log for chainID mismatch, it is not a real error any more

Testing performed to validate your change

Copy link

codecov bot commented Oct 8, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 61.53%. Comparing base (c613181) to head (0f562ee).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
x/evm/ante/sig.go 0.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1892      +/-   ##
==========================================
+ Coverage   61.39%   61.53%   +0.14%     
==========================================
  Files         263      263              
  Lines       23314    23314              
==========================================
+ Hits        14313    14347      +34     
+ Misses       7989     7956      -33     
+ Partials     1012     1011       -1     
Files with missing lines Coverage Δ
x/evm/ante/sig.go 78.20% <0.00%> (ø)

... and 3 files with indirect coverage changes

@yzang2019 yzang2019 merged commit fc9a0bd into main Oct 11, 2024
48 of 49 checks passed
@yzang2019 yzang2019 deleted the yzang/reduce-noisy-log branch October 11, 2024 05:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants