Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SERF1677] Add sentry recovery to Kafka consumer #111

Merged
merged 1 commit into from
Jun 20, 2024

Conversation

laynax
Copy link
Contributor

@laynax laynax commented Jun 20, 2024

Description

This PR adds a recovery mechanism to Kafka's partition consumer so that we capture one if happening while consuming a message.

Testing considerations

NaN

Checklist

  • Prefixed the PR title with the JIRA ticket code
  • Performed simple, atomic commits with [good commit messages][commit messages]
  • Verified that the commit history is linear and commits are squashed as necessary
  • Thoroughly tested the changes in development and/or staging
  • Updated the README.md as necessary

Related links

@laynax laynax requested a review from a team as a code owner June 20, 2024 09:27
@laynax laynax requested review from Neurostep and fotos June 20, 2024 09:27
fotos
fotos previously approved these changes Jun 20, 2024
Copy link
Contributor

@fotos fotos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM 🚀

I'm not sure we should be bringing sentry into this package (this applies to #109 as well) – maybe there is a better integration point?

Anyway – I'm approving to keep us moving forward and @Neurostep can take another look after he's back.

pkg/pubsub/kafka/partitionconsumer.go Outdated Show resolved Hide resolved
Copy link
Contributor

@fotos fotos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM 🚀

@laynax laynax merged commit 91f05cb into main Jun 20, 2024
6 checks passed
@laynax laynax deleted the laynax/SERF-1677/rec-mw-kafka branch June 20, 2024 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants